[SYCL][CUDA] Handle large Y/Z range dimensions. #7968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks per grid limits.
This was referenced Jan 10, 2023
|
Please, add
https://github.com/intel/llvm/blob/sycl/CONTRIBUTING.md#pull-request I also recommend linking this PR to the issue #7854 to the issue automatically when PR is merged. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
mmoadeli
changed the title
|
/verify with intel/llvm-test-suite#1500 |
… size. - Improve variable namings
@steffenlarsen, thanks, it's updated. |
bader
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jan 25, 2023
Provides a test for intel/llvm#7968
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…te#1500) Provides a test for intel#7968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dimensions passed to sycl::range, determine the blocks per grid and threads per blocks. Currently, calculation of thread per blocks only performed for the x dimension. This means the blocks per grid for y and z dimensions passed to cuLaunchKernel, directly come from the sycl::range arguments. This can result in an error returned on calling cuLaunchKernel, when those parameters for y and z dimensions are larger than 65535.
This PR offers a simple tuning of thread per block for larger (over 65535) values of Y and Z dimensions to make the associated blocks per grid within the allowed range.