Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Test the case where range is over allowed limit. #1500

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

mmoadeli
Copy link

Provides a test for
intel/llvm#7968

@mmoadeli mmoadeli requested a review from a team as a code owner January 10, 2023 01:19
@mmoadeli mmoadeli requested a review from bso-intel January 10, 2023 01:19
@mmoadeli
Copy link
Author

mmoadeli commented Jan 10, 2023

/verify with intel/llvm#7968

@bader
Copy link

bader commented Jan 10, 2023

verify /intel/llvm#7968

@mmoadeli, the command format is

/verify with <link to the PR>

@mmoadeli
Copy link
Author

/verify with intel/llvm#7968

@abagusetty
Copy link

@mmoadeli Since this test works for HIP backend as well. May be: REQUIRES: gpu, cuda, hip ?

@bader
Copy link

bader commented Jan 11, 2023

@mmoadeli Since this test works for HIP backend as well. May be: REQUIRES: gpu, cuda, hip ?

This will disable the test. There are no machines in CI where all three features are true at the same time.

@bader
Copy link

bader commented Jan 11, 2023

/verify with intel/llvm#7968

FYI: /verify with validates the change with OpenCL and Level Zero only. Tests requiring CUDA are not covered.

@abagusetty
Copy link

Thanks @bader. Would REQUIRES: opencl || level_zerp || cuda || hip enables for appropriate combinations.

@bader
Copy link

bader commented Jan 11, 2023

Thanks @bader. Would REQUIRES: opencl || level_zerp || cuda || hip enables for appropriate combinations.

This looks like we expect the test to run with any back end, so it's better just remove REQUIRES at all.

@abagusetty
Copy link

Thanks for the pointer.

@mmoadeli
Copy link
Author

/verify with intel/llvm#7968

thanks @bader, @abagusetty, REQUIRES is removed.

@mmoadeli
Copy link
Author

/verify with intel/llvm#7968

@bader
Copy link

bader commented Jan 25, 2023

@intel/llvm-reviewers-runtime, @bso-intel, ping.

Copy link

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 767d532 into intel:intel Jan 25, 2023
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
intel#1402) (intel#1500)

[SYCL] Reflect support of  AMD, NVIDIA GPU architectures as argument of the -fsycl-targets.

Co-authored-by: mmoadeli <mmoadeli@hotmail.co.uk>
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants