Skip to content

[NFC][SYCL][Reduction] Remove dead code #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2022
Merged

[NFC][SYCL][Reduction] Remove dead code #7437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 7 additions & 19 deletions sycl/include/sycl/reduction.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,28 +830,16 @@ template <class FunctorTy> void withAuxHandler(handler &CGH, FunctorTy Func) {
}
} // namespace reduction

// This method is used for implementation of parallel_for accepting 1 reduction.
// TODO: remove this method when everything is switched to general algorithm
// implementing arbitrary number of reductions in parallel_for().
/// Copies the final reduction result kept in read-write accessor to user's
/// accessor. This method is not called for user's read-write accessors
/// requiring update-write to it.
template <typename KernelName, class Reduction>
std::enable_if_t<!Reduction::is_usm>
reduSaveFinalResultToUserMem(handler &CGH, Reduction &Redu) {
auto InAcc = Redu.getReadAccToPreviousPartialReds(CGH);
associateWithHandler(CGH, &Redu.getUserRedVar(), access::target::device);
CGH.copy(InAcc, Redu.getUserRedVar());
}

// This method is used for implementation of parallel_for accepting 1 reduction.
// TODO: remove this method when everything is switched to general algorithm
// implementing arbitrary number of reductions in parallel_for().
/// Copies the final reduction result kept in read-write accessor to user's
/// USM memory.
template <typename KernelName, class Reduction>
std::enable_if_t<Reduction::is_usm>
reduSaveFinalResultToUserMem(handler &CGH, Reduction &Redu) {
void reduSaveFinalResultToUserMem(handler &CGH, Reduction &Redu) {
static_assert(Reduction::is_usm,
"All implementations using this helper are expected to have "
"USM reduction, not a buffer-based one.");
size_t NElements = Reduction::num_elements;
auto InAcc = Redu.getReadAccToPreviousPartialReds(CGH);
auto UserVarPtr = Redu.getUserRedVar();
Expand Down Expand Up @@ -1144,7 +1132,7 @@ template <> struct NDRangeReduction<reduction::strategy::range_basic> {
}
});

if (Reduction::is_usm)
if constexpr (Reduction::is_usm)
reduction::withAuxHandler(CGH, [&](handler &CopyHandler) {
reduSaveFinalResultToUserMem<KernelName>(CopyHandler, Redu);
});
Expand Down Expand Up @@ -1389,7 +1377,7 @@ struct NDRangeReduction<
});
} // end while (NWorkItems > 1)

if (Reduction::is_usm) {
if constexpr (Reduction::is_usm) {
reduction::withAuxHandler(CGH, [&](handler &CopyHandler) {
reduSaveFinalResultToUserMem<KernelName>(CopyHandler, Redu);
});
Expand Down Expand Up @@ -1589,7 +1577,7 @@ template <> struct NDRangeReduction<reduction::strategy::basic> {
});
} // end while (NWorkItems > 1)

if (Reduction::is_usm) {
if constexpr (Reduction::is_usm) {
reduction::withAuxHandler(CGH, [&](handler &CopyHandler) {
reduSaveFinalResultToUserMem<KernelName>(CopyHandler, Redu);
});
Expand Down