Skip to content

[NFC][SYCL][Reduction] Remove dead code #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

aelovikov-intel
Copy link
Contributor

Needs changing "if"->"if constexpr" in few places for that, but that's for the better.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner November 17, 2022 17:36
Needs changing "if"->"if constexpr" in few places for that, but that's
for the better.
@aelovikov-intel
Copy link
Contributor Author

The unrelated

SYCL :: GroupAlgorithm/SYCL2020/sort.cpp

failure is being addressed at intel/llvm-test-suite#1396.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pvchupin pvchupin merged commit a57d0ae into intel:sycl Nov 18, 2022
@aelovikov-intel aelovikov-intel deleted the reduction-remove-dead branch April 7, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants