Skip to content

[SYCL][OpenCL] Ban AMD OpenCL platform (#5825) #6878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[SYCL][OpenCL] Ban AMD OpenCL platform (#5825) #6878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions sycl/source/detail/platform_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,23 +75,28 @@ static bool IsBannedPlatform(platform Platform) {
// To avoid problems on default users and deployment of DPC++ on platforms
// where CUDA is available, the OpenCL support is disabled.
//
auto IsNVIDIAOpenCL = [](platform Platform) {
// There is also no support for the AMD HSA backend for OpenCL consumption,
// as well as reported problems with device queries, so AMD OpenCL support
// is disabled as well.
//
auto IsMatchingOpenCL = [](platform Platform, const std::string_view name) {
if (getSyclObjImpl(Platform)->is_host())
return false;

const bool HasCUDA = Platform.get_info<info::platform::name>().find(
"NVIDIA CUDA") != std::string::npos;
const bool HasNameMatch = Platform.get_info<info::platform::name>().find(
name) != std::string::npos;
const auto Backend =
detail::getSyclObjImpl(Platform)->getPlugin().getBackend();
const bool IsCUDAOCL = (HasCUDA && Backend == backend::opencl);
if (detail::pi::trace(detail::pi::TraceLevel::PI_TRACE_ALL) && IsCUDAOCL) {
std::cout << "SYCL_PI_TRACE[all]: "
<< "NVIDIA CUDA OpenCL platform found but is not compatible."
<< std::endl;
const bool IsMatchingOCL = (HasNameMatch && Backend == backend::opencl);
if (detail::pi::trace(detail::pi::TraceLevel::PI_TRACE_ALL) &&
IsMatchingOCL) {
std::cout << "SYCL_PI_TRACE[all]: " << name
<< " OpenCL platform found but is not compatible." << std::endl;
}
return IsCUDAOCL;
return IsMatchingOCL;
};
return IsNVIDIAOpenCL(Platform);
return IsMatchingOpenCL(Platform, "NVIDIA CUDA") ||
IsMatchingOpenCL(Platform, "AMD Accelerated Parallel Processing");
}

// This routine has the side effect of registering each platform's last device
Expand Down