[SYCL] Remove mentions of host device from in-tree LIT tests #6683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review. The removed tests will be moved to the test-suite in an upcoming PR. |
steffenlarsen
added a commit
to steffenlarsen/llvm-test-suite
that referenced
this pull request
Sep 2, 2022
With the removal of the host device a selection of in-tree LIT tests can potentially fail as they rely on a device being available on the system. intel/llvm#6683 removes these tests, but since most are still valid this commit migrates these to the test-suite. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
v-klochkov
previously approved these changes
Sep 2, 2022
bader
changed the title
AlexeySachkov
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Sep 7, 2022
With the removal of the host device a selection of in-tree LIT tests can potentially fail as they rely on a device being available on the system. intel/llvm#6683 removes these tests, but since most are still valid this commit migrates these to the test-suite. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
@steffenlarsen, ping. |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
previously approved these changes
Sep 9, 2022
…e-tests-using-host-device
v-klochkov
previously approved these changes
Sep 9, 2022
v-klochkov
dismissed
their stale review
One of tests started failing. Need to re-check: regression/fsycl-host-compiler.cpp
v-klochkov
reviewed
Sep 9, 2022
| auto B = b.get_access<access::mode::write>(cgh); | ||
| cgh.parallel_for<class test>(range<1>(3), [=](id<1> idx) { | ||
| B[idx] = 1; | ||
| cgh.host_task([=]() { |
There was a problem hiding this comment.
Does 'host_task' remains supported even though 'host' is being removed?
There was a problem hiding this comment.
Yes! host_task does not have anything to do with the host device. However, these tests are arguably not independent from the presence of a device, so they should be moved to the test-suite.
There was a problem hiding this comment.
host_task is executed on host and host != host device.
host device term only exists in SYCL 1.2.1 specification and it means the ability to execute SYCL Kernel Functions even if no OpenCL devices are available. host term still exists in SYCL 2020 and host_task is related to it, not to host device
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
fsycl-host-compiler tests were moved to the test suite in intel/llvm-test-suite#1240 |
v-klochkov
previously approved these changes
Sep 9, 2022
…e-tests-using-host-device
v-klochkov
approved these changes
Sep 12, 2022
steffenlarsen
pushed a commit
that referenced
this pull request
Sep 15, 2022
The idea behind this PR is to introduce an infrastructure which allows to write unit-tests, which are not dependent on a presence of actual backends (like OpenCL, L0, etc.) or devices (like CPU, GPU, etc.). Motivation for the patch: host device is going to be removed and we have a number of in-tree LIT tests, which can't pass if there are no devices available, so they are likely to be removed/disabled in short-term (#6683), unless we move them into llvm-test-suite or unit-tests with new infrastructure suggested here. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com> Co-authored-by: Sachkov, Alexey <alexey.sachkov@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
With the removal of the host device a selection of in-tree LIT tests can potentially fail as they rely on a device being available on the system. intel#6683 removes these tests, but since most are still valid this commit migrates these to the test-suite. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…vm-test-suite#1195) With the removal of the host device a selection of in-tree LIT tests can potentially fail as they rely on a device being available on the system. intel#6683 removes these tests, but since most are still valid this commit migrates these to the test-suite. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
PietroGhg
added a commit
to PietroGhg/llvm
that referenced
this pull request
Apr 24, 2023
…ntel#6683)" This reverts commit ba01a30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.