This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Migrate remaining device-dependent in-tree LIT tests #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the removal of the host device a selection of in-tree LIT tests can potentially fail as they rely on a device being available on the system. intel/llvm#6683 removes these tests, but since most are still valid this commit migrates these to the test-suite. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
v-klochkov
reviewed
Sep 2, 2022
There was a problem hiding this comment.
I think this ESIMD/vadd.cpp is not needed.
We already have ESIMD/vadd_1d.cpp,vadd_2d.cpp,vadd_2d_acc.cpp in test-suite.
The only thing that is different in vadd.cpp is the type 'int' vs vadd_1d.cpp/float.
But the lack of type checks need to be by templating the test/kernel in the existing vadd_1d.cpp test.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
Thank you for removing 'vadd.cpp' test. After that removal, review from ESIMD is not needed. |
cperkinsintel
approved these changes
Sep 6, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
With the removal of the host device a selection of in-tree LIT tests can potentially fail as they rely on a device being available on the system. intel/llvm#6683 removes these tests, but since most are still valid this commit migrates these to the test-suite. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…vm-test-suite#1195) With the removal of the host device a selection of in-tree LIT tests can potentially fail as they rely on a device being available on the system. intel#6683 removes these tests, but since most are still valid this commit migrates these to the test-suite. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the removal of the host device a selection of in-tree LIT tests can potentially fail as they rely on a device being available on the system. intel/llvm#6683 removes these tests, but since most are still valid this commit migrates these to the test-suite.