[SYCL][ABI Break] Remove ext::oneapi::reduction #6634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also move the implementation from the extension header to the regular sycl/reduction.hpp. There might be some simplifications in the implementation enabled by that but they are left for a future PR.
v-klochkov
previously approved these changes
Aug 23, 2022
aelovikov-intel
added a commit
to aelovikov-intel/llvm-test-suite
that referenced
this pull request
Aug 23, 2022
|
One failure seems valid - addressing it in intel/llvm-test-suite#1176. Once that passes, PRs have to be merged together. |
Also remove now useless using directives
aelovikov-intel
commented
Aug 24, 2022
Comment on lines
+59
to
+74
| /// Class that is used to represent objects that are passed to user's lambda | ||
| /// functions and representing users' reduction variable. | ||
| /// The generic version of the class represents those reductions of those | ||
| /// types and operations for which the identity value is not known. | ||
| /// The View template describes whether the reducer owns its data or not: if | ||
| /// View is 'true', then the reducer does not own its data and instead provides | ||
| /// a view of data allocated elsewhere (i.e. via a reference or pointer member); | ||
| /// if View is 'false', then the reducer owns its data. With the current default | ||
| /// reduction algorithm, the top-level reducers that are passed to the user's | ||
| /// lambda contain a private copy of the reduction variable, whereas any reducer | ||
| /// created by a subscript operator contains a reference to a reduction variable | ||
| /// allocated elsewhere. The Subst parameter is an implementation detail and is | ||
| /// used to spell out restrictions using 'enable_if'. | ||
| template <typename T, class BinaryOperation, int Dims, size_t Extent, | ||
| bool View = false, typename Subst = void> | ||
| class reducer; |
There was a problem hiding this comment.
This was moved from sycl::ext::oneapi::detail to sycl because
- That's what standard seems to say
- To make it work with ESIMD processing. We need it disallowed and everything in
sycl::detailis allowed, while only an explicit subset ofsyclis allowed in there.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 12, 2022
* ext::oneapi::reduction removed in intel#6634 * sycl::item in kernel supported since intel#7478 * sycl::range + many reductions implemented in intel#7456 There might be other things that have been implemented already, but I cannot immediately identify them, if any.
bader
pushed a commit
that referenced
this pull request
Dec 13, 2022
* ext::oneapi::reduction removed in #6634 * sycl::item in kernel supported since #7478 * sycl::range + many reductions implemented in #7456 * CPU reduction performance implemented in #6164 * span support implemented in #6019 There might be other things that have been implemented already, but I cannot immediately identify them, if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also move the implementation from the extension header to the
regular sycl/reduction.hpp.
There might be some simplifications in the implementation enabled by
that but they are left for a future PR.