Skip to content

[SYCL][CUDA] reverted #6577 #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

JackAKirk
Copy link
Contributor

Signed-off-by: JackAKirk jack.kirk@codeplay.com

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@steffenlarsen
Copy link
Contributor

@JackAKirk - Can you confirm that the CUDA test failures are unrelated?

@JackAKirk
Copy link
Contributor Author

@JackAKirk - Can you confirm that the CUDA test failures are unrelated?

The failure Assert/assert_in_simultaneously_multiple_tus.cpp is I think unrelated to this PR and the changes that this PR is reverting: #6577

At first I thought that the failures of tests like Assert/assert_in_simultaneously_multiple_tus.cpp could be due to #6361 because the failures followed soon afterwards and it initially looked like that PR added calls to increment the context without a mutex but I was too quick to put up #6577 and missed that the refcount was std::atomic, hence the reversion here.
I am working on a fix for what I believe is the true origin of these flaky test failures, as I updated here: #6463 (comment)

@steffenlarsen steffenlarsen merged commit e20fefc into intel:sycl Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants