[SYCL][CUDA] Use context mutex in refcount inc/dec #6577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
sergey-semenov
approved these changes
Aug 16, 2022
|
@JackAKirk On second thought, shouldn't this patch do effectively nothing except add some overhead since |
Yes you are right... sorry, can this commit be reverted? I was too quick with this, the problem appeared to start soon after a commit that added additional usage of incrementing the ref count. I'll continue investigating #6463 |
|
@JackAKirk I think it should be, please open a PR with the revert. |
OK sure |
Here it is #6603 |
steffenlarsen
pushed a commit
that referenced
this pull request
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context wasn't using its mutex when incrementing/decrementing the ref count, even though multiple threads may attempt this at the same time in multithreaded applications such as in assert_in_simultaneously_multiple_tus.cpp. This may fix #6463 but I can't be sure of this because I can't reproduce flaky CI test failures in #6463 locally.
Signed-off-by: JackAKirk jack.kirk@codeplay.com