[SYCL][ABI-break] Switch to struct information descriptors #6467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes information descriptors from enum class elements to structs in accordance with SYCL 2020 spec. Additionally, it removes some deprecated information queries that were dropped in either SYCL 2020 or the corresponding extension and deprecates those listed as such in SYCL 2020 spec.
|
Need to update windows ABI test as well, but I'm running into some issues on my Windows machine. Will follow up. |
|
/verify with intel/llvm-test-suite#1107 |
|
/verify with intel/llvm-test-suite#1107 |
|
/verify with intel/llvm-test-suite#1107 |
|
@againull Could you please review this one and the llvm-test-suite change? |
|
@againull @intel/llvm-reviewers-runtime ping |
|
Since this breaks ABI, this PR should increment |
|
/verify with intel/llvm-test-suite#1107 |
|
/verify with intel/llvm-test-suite#1107 |
againull
approved these changes
Aug 4, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes information descriptors from enum class elements to
structs in accordance with SYCL 2020 spec. Additionally, it removes some
deprecated information queries that were dropped in either SYCL 2020 or
the corresponding extension and deprecates those listed as such in SYCL
2020 spec.