-
Notifications
You must be signed in to change notification settings - Fork 30
Fix build break with open-source intel/llvm DPC++ #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View rendered docs @ https://intelpython.github.io/dpctl/pulls/876/index.html |
ce9e502
to
d161ab2
Compare
I wonder if it makes sense to define For older compilers the 1d, 2d version would simply take the first and the first two entries from the triplet returned by |
d161ab2
to
52254ea
Compare
dpctl.SyclDevice.max_work_iterm_sizes is deprecated.
Reflactor common duplicated fixtures for device properties checks out into a common file made available to both `test_sycl_device.py` and `test_sycl_queue.py` via `conftest.py` per https://stackoverflow.com/questions/13641973/how-and-where-does-py-test-find-fixtures MaxWorkItemSizes1d, MaxWorkItemSizes2d and MaxWorkItemSizes3d properties are added.
@diptorupd I have implemented The Frankly, I dislike introducing these warnings. I'd say we should just remove them. It is not used in |
ed34668
to
81a14dc
Compare
Ok @diptorupd , I think I am going to merge this to fix build with intel/llvm DPC++ and address your feedback in a separate PR. |
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Due to change in intel/llvm#6467 the build of SYCLInterface library is failing when using nightly sycl_bundle of intel/llvm DPC++.
This PR uses
__SYCL_COMPILER_VERSION
to keep both current oneAPI DPC++ and intel/llvm DPC++ working when compiling the library.Note that
sycl::device::info::max_work_item_sizes
parameter is no longer in the SYCL 2020 spec rev 5, instead one should usesycl::device::info::max_work_item_sizes<1>
,sycl::device::info::max_work_item_sizes<2>
,sycl::device::info::max_work_item_sizes<3>
and hencedpctl
interfaces must be updated at some point.