[SYCL] Minor fixes to device_global properties #5778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes includes device_global properties as part of sycl.hpp and fixes some minor oversights in the implementation. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
s-kanaev
approved these changes
Mar 10, 2022
| @@ -6,7 +6,10 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #pragma once | |||
There was a problem hiding this comment.
I am truly filled with shame. 😅
CTS and other existing tests (like std compatibility) fail without these changes, after adding it to sycl.hpp. More test will follow once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes includes device_global properties as part of sycl.hpp and fixes some minor oversights in the implementation.