Skip to content

[CI] Revert w/a for FPGA emu bug #5775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alexbatashev
Copy link
Contributor

Containers were updated with fixed FPGA emulator packages.

@alexbatashev alexbatashev marked this pull request as ready for review March 10, 2022 09:55
@alexbatashev alexbatashev requested a review from bader as a code owner March 10, 2022 09:55
@bader
Copy link
Contributor

bader commented Mar 10, 2022

Timed Out : 8
Failed : 1

Do you know what might cause this issue?

@alexbatashev
Copy link
Contributor Author

One failed test is a known issue, 8 timed out tests require investigation

@bader
Copy link
Contributor

bader commented Mar 10, 2022

One failed test is a known issue

Is it related to this change? If no, please, disable the failing test to avoid false alarms.

8 timed out tests require investigation

The same - please, check that these are not related to your patch.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix pre-commit fails.

@alexbatashev
Copy link
Contributor Author

Is it related to this change? If no, please, disable the failing test to avoid false alarms.

See intel/llvm-test-suite#907

The same - please, check that these are not related to your patch

Looking into it

@bader
Copy link
Contributor

bader commented Mar 10, 2022

FYI. I see something related in pre-commit for #5778.

See https://github.com/intel/llvm/runs/5496313460?check_suite_focus=true.


Timed Out Tests (7):
SYCL :: KernelAndProgram/multiple-kernel-linking.cpp
SYCL :: Plugin/level_zero_batch_test.cpp
SYCL :: Plugin/level_zero_batch_test_copy_with_compute.cpp
SYCL :: Plugin/retain_events.cpp
SYCL :: Printf/char.cpp
SYCL :: Printf/float.cpp
SYCL :: USM/copy.cpp

Testing Time: 1654.86s
Unsupported : 184
Passed : 578
Expectedly Failed: 38
Timed Out : 7

@bader
Copy link
Contributor

bader commented Mar 10, 2022

Another one - https://github.com/intel/llvm/runs/5496822497?check_suite_focus=true.
It looks like a regression introduced before your patch.

@bader
Copy link
Contributor

bader commented Mar 11, 2022

@againull, we reviewed recent changes we made to the sycl branch and identified #5231 as one of the changes that might cause the timeout issues discussed above. Could you check if #5231 is related to them, please?

@bader
Copy link
Contributor

bader commented Mar 11, 2022

Another instance: https://github.com/intel/llvm/runs/5503076361?check_suite_focus=true. Pre-commit for #5772.

@bader
Copy link
Contributor

bader commented Mar 11, 2022

A different picture here: https://github.com/intel/llvm/runs/5504737044?check_suite_focus=true

600.02s: SYCL :: ESIMD/kmeans/kmeans.cpp
595.17s: SYCL :: ESIMD/matrix_transpose_glb.cpp
592.98s: SYCL :: ESIMD/matrix_transpose_usm.cpp
591.00s: SYCL :: ESIMD/noinline_args_size/noinline_args_char_int_size_192.cpp
590.90s: SYCL :: ESIMD/noinline_args_size/noinline_args_char_int_size_512.cpp
590.84s: SYCL :: ESIMD/noinline_args_size/noinline_args_char_int_size_256.cpp
589.63s: SYCL :: ESIMD/noinline_args_size/noinline_args_char_int_size_64.cpp
589.43s: SYCL :: ESIMD/noinline_args_size/noinline_args_char_int_size_96.cpp
588.61s: SYCL :: ESIMD/noinline_args_size/noinline_args_int_size_192.cpp
588.12s: SYCL :: ESIMD/noinline_args_size/noinline_args_int_size_512.cpp
587.82s: SYCL :: ESIMD/noinline_args_size/noinline_args_int_size_256.cpp
586.85s: SYCL :: ESIMD/noinline_args_size/noinline_args_int_size_64.cpp

@againull
Copy link
Contributor

againull commented Mar 11, 2022

@againull, we reviewed recent changes we made to the sycl branch and identified #5231 as one of the changes that might cause the timeout issues discussed above. Could you check if #5231 is related to them, please?

@bader I am trying to reproduce timeout failures using intel/llvm by running whole llvm-test-suite multiple times with -j 12, but no luck so far. Actually I was doing this during the last week to test this patch and didn't face timeout issues.

I don't have information about how many testing jobs we run on the same machine, how many threads do we use (-j threads]) and if smth changed recently in the why we run testing jobs in CI. Also I need an access to one of the CI machines where problem is reproduced. Who can provide me this information?

@againull
Copy link
Contributor

@againull, we reviewed recent changes we made to the sycl branch and identified #5231 as one of the changes that might cause the timeout issues discussed above. Could you check if #5231 is related to them, please?

@bader I've created a PR #5794 which reverts #5231. 5 tests failed wih timeout:
https://github.com/intel/llvm/runs/5518337723?check_suite_focus=true

I hope this proves that #5231 is not a guilty commit for timeout failures.

@github-actions github-actions bot added the Stale label Sep 8, 2022
@github-actions github-actions bot closed this Oct 9, 2022
@alexbatashev alexbatashev deleted the re_enable_fpga_emu branch October 9, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants