[CI] Install cm-compiler in drivers image #5128
Conversation
| RUN python3 /get_release.py intel/intel-graphics-compiler $igc_tag \ | ||
| | grep ".*deb" \ | ||
| | wget -qi - && \ | ||
| python3 /get_release.py intel/compute-runtime $compute_runtime_tag \ | ||
| | grep -E ".*((deb)|(sum))" \ | ||
| | wget -qi - && \ | ||
| sha256sum -c *.sum &&\ | ||
| python3 /get_release.py intel/cm-compiler $cm_tag \ |
There was a problem hiding this comment.
https://intel.github.io/llvm-docs/GetStartedGuide.html - I don't see cm-compiler in the list of prerequisites in our documentation.
@dongkyunahn-intel, @kbobrovs, is cm-compiler required? If so, please, update the documentation.
There was a problem hiding this comment.
We have a test in LLVM Test Suite, that explicitly requires CM: https://github.com/intel/llvm-test-suite/blob/74e49b34513f3a24c939be3b8aada17aa83b5d53/SYCL/OnlineCompiler/online_compiler_common.hpp#L104-L105
There was a problem hiding this comment.
I agree that cm-compiler might be needed to test all DPC++ features, but tests should not fail if it's not installed on the system.
LIT config must have corresponding feature and skip the test if dependencies are not installed. The same way it's done for OpenCL runtime in https://github.com/intel/llvm-test-suite/blob/74e49b34513f3a24c939be3b8aada17aa83b5d53/SYCL/OnlineCompiler/online_compiler_OpenCL.cpp
There was a problem hiding this comment.
Fair point, added a new feature to llvm-test-suite here intel/llvm-test-suite#611
There was a problem hiding this comment.
@bader, the only DPC++ feature CM compiler is required for is online compilation from CM source. CM compilation should be available in driver/ocloc. Maybe something changed since this feature was committed.
-options <options> Optional OpenCL C compilation options
as defined by OpenCL specification.
Special options for Vector Compute:
-vc-codegen <vc options> compile from SPIRV
-cmc <cm-options> compile from CM sources
There was a problem hiding this comment.
@v-klochkov, can you please comment?
ocloc calls corresponding CM dynamic library if -cmc is passed. So, CM compiler is needed for that LIT test verifying online_compiler feature.
I also agree that the test should not fail if CM is not installed and the patch intel/llvm-test-suite#611 is a good move. I added my approval there as well - it is ready to be merged now.
There was a problem hiding this comment.
@bader, I had an impression that driver + ocloc encompasses needed headers and compiler itself and that there is no dependence on stand-alone CM compiler. @v-klochkov - is this not correct?
There was a problem hiding this comment.
@bader, I had an impression that driver + ocloc encompasses needed headers and compiler itself and that there is no dependence on stand-alone CM compiler. @v-klochkov - is this not correct?
as soon as you give -cmc to libocloc, it starts requiring another lib* cm* library doing the compilation of CM source.
There was a problem hiding this comment.
It sounds like driver+ocloc is not enough and there is a dependency on https://github.com/intel/cm-compiler to compile CM sources.
There was a problem hiding this comment.
Right. I checked recent distros and I don't see the libcm* there anymore.
There was a problem hiding this comment.
@kbobrovs, @dongkyunahn-intel, ping. Any thoughts on this change?
* upstream/sycl: (5961 commits) [SYCL] Implement discard_events extension (intel#5026) [SYCL][NFC] Fix unused parameter warning in piQueueFlush (intel#5139) [SYCL][XPTI] Fix static analysis tool warnings (intel#5040) [CI] Switch post-commit jobs to self-hosted runners (intel#5147) [SYCL] Fix support for classes implicitly converted from items in parallel_for (intel#5118) [SYCL][HIP] Fix platform query in USM alloc info (intel#5140) [Docker] Add workarounds for two SYCL issues (intel#5143) [CI] Install cm-compiler in drivers image (intel#5128) [ESIMD] Add support for an arbitrary number of elements to simd::copy_from/to (intel#5135) [SYCL] Add number HW threads per EU query (intel#4901) [CI] Refactor workflow files (intel#5134) [CI] Enable HIP and CUDA plugins in GitHub Actions builds (intel#5087) [SYCL] Implement queue flushing (intel#5052) Disable issue labeler in LLVM forks Modify translation for disable_loop_pipelining metadata Add SPIR-V friendly translation for OpLoad and OpStore Fix return type postfix for SPIR-V Friendly IR Restrict special handling of sampler OpVariable only to UniformConstant Add lowering for llvm.bswap intrinsic Fix translation of OpVariable with OpSamplerType ...
At least one test in llvm-test-suite uses C for metal. Deploy required components to run it.