Skip to content

[CI] Install cm-compiler in drivers image #5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2021
Merged

[CI] Install cm-compiler in drivers image #5128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion devops/containers/ubuntu2004_intel_drivers.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ ENV DEBIAN_FRONTEND=noninteractive

ARG compute_runtime_tag=latest
ARG igc_tag=latest
ARG cm_tag=latest
ARG tbb_tag=latest
ARG fpgaemu_tag=latest
ARG cpu_tag=latest
Expand All @@ -15,14 +16,17 @@ RUN apt update && apt install -yqq wget

COPY scripts/get_release.py /

# Install IGC and NEO
# Install IGC, CM and NEO
RUN python3 /get_release.py intel/intel-graphics-compiler $igc_tag \
| grep ".*deb" \
| wget -qi - && \
python3 /get_release.py intel/compute-runtime $compute_runtime_tag \
| grep -E ".*((deb)|(sum))" \
| wget -qi - && \
sha256sum -c *.sum &&\
python3 /get_release.py intel/cm-compiler $cm_tag \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://intel.github.io/llvm-docs/GetStartedGuide.html - I don't see cm-compiler in the list of prerequisites in our documentation.
@dongkyunahn-intel, @kbobrovs, is cm-compiler required? If so, please, update the documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a test in LLVM Test Suite, that explicitly requires CM: https://github.com/intel/llvm-test-suite/blob/74e49b34513f3a24c939be3b8aada17aa83b5d53/SYCL/OnlineCompiler/online_compiler_common.hpp#L104-L105

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that cm-compiler might be needed to test all DPC++ features, but tests should not fail if it's not installed on the system.
LIT config must have corresponding feature and skip the test if dependencies are not installed. The same way it's done for OpenCL runtime in https://github.com/intel/llvm-test-suite/blob/74e49b34513f3a24c939be3b8aada17aa83b5d53/SYCL/OnlineCompiler/online_compiler_OpenCL.cpp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, added a new feature to llvm-test-suite here intel/llvm-test-suite#611

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bader, the only DPC++ feature CM compiler is required for is online compilation from CM source. CM compilation should be available in driver/ocloc. Maybe something changed since this feature was committed.

  -options <options>            Optional OpenCL C compilation options
                                as defined by OpenCL specification.
                                Special options for Vector Compute:
                                -vc-codegen <vc options> compile from SPIRV
                                -cmc <cm-options> compile from CM sources

Copy link
Contributor

@v-klochkov v-klochkov Dec 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-klochkov, can you please comment?

ocloc calls corresponding CM dynamic library if -cmc is passed. So, CM compiler is needed for that LIT test verifying online_compiler feature.
I also agree that the test should not fail if CM is not installed and the patch intel/llvm-test-suite#611 is a good move. I added my approval there as well - it is ready to be merged now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bader, I had an impression that driver + ocloc encompasses needed headers and compiler itself and that there is no dependence on stand-alone CM compiler. @v-klochkov - is this not correct?

Copy link
Contributor

@v-klochkov v-klochkov Dec 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bader, I had an impression that driver + ocloc encompasses needed headers and compiler itself and that there is no dependence on stand-alone CM compiler. @v-klochkov - is this not correct?

as soon as you give -cmc to libocloc, it starts requiring another lib* cm* library doing the compilation of CM source.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like driver+ocloc is not enough and there is a dependency on https://github.com/intel/cm-compiler to compile CM sources.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I checked recent distros and I don't see the libcm* there anymore.

| grep ".*deb" \
| wget -qi - && \
dpkg -i *.deb && rm *.deb *.sum

RUN mkdir /runtimes
Expand Down