Skip to content

[SYCL][DOC] Spec for discard queue events #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 23, 2021

Conversation

alexanderfle
Copy link
Contributor

@alexanderfle alexanderfle commented Nov 9, 2021

See extension document for SYCL describing discard queue events behaviour

@Pennycook Pennycook marked this pull request as ready for review November 10, 2021 17:12
@Pennycook Pennycook requested a review from a team as a code owner November 10, 2021 17:12
@Pennycook
Copy link
Contributor

@alexanderfle Apologies, I didn't mean to mark this as ready to review. My finger slipped, and I can't find a way to mark the PR as a draft again.

Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
@alexanderfle alexanderfle marked this pull request as draft November 10, 2021 17:20
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
@alexanderfle alexanderfle changed the title [SYCL][DOC] Spec for avoid event creation [SYCL][DOC] Spec for discard queue events Nov 15, 2021
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
@alexanderfle
Copy link
Contributor Author

alexanderfle commented Nov 18, 2021

@Pennycook , @gmlueck , @romanovvlad, are there any other comments on the current version of the document?
Сan we open the draft for review?

Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted one formatting issue during another read through. I think this can be opened for review.

…_QUEUE_EVENTS.asciidoc

Co-authored-by: John Pennycook <john.pennycook@intel.com>
@alexanderfle
Copy link
Contributor Author

@gmlueck , btw, Should we add to the document that Level Zero will temporarily work without optimization? Since Level Zero support is required to be able to not create a low-level event.

@gmlueck
Copy link
Contributor

gmlueck commented Nov 22, 2021

@gmlueck , btw, Should we add to the document that Level Zero will temporarily work without optimization? Since Level Zero support is required to be able to not create a low-level event.

This depends. Do we plan to implement the Level Zero support at the same time that we implement the DPC++ support? If so, there is no need to document that limitation because it won't exist when this extension is implemented.

@alexanderfle
Copy link
Contributor Author

This depends. Do we plan to implement the Level Zero support at the same time that we implement the DPC++ support? If so, there is no need to document that limitation because it won't exist when this extension is implemented.

Ok, I expect DPC ++ support to be added faster than Level Zero plugin support. So I'll add a few words about that.

@alexanderfle alexanderfle requested a review from gmlueck November 22, 2021 15:04
@alexanderfle alexanderfle marked this pull request as ready for review November 22, 2021 15:50
gmlueck
gmlueck previously approved these changes Nov 22, 2021
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…_QUEUE_EVENTS.asciidoc

Co-authored-by: John Pennycook <john.pennycook@intel.com>
@bader bader merged commit 23ca24b into intel:sycl Nov 23, 2021
romanovvlad pushed a commit that referenced this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants