-
Notifications
You must be signed in to change notification settings - Fork 770
[SYCL][DOC] Spec for discard queue events #4922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][DOC] Spec for discard queue events #4922
Conversation
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/Avoid_event_creation/avoid_event_creation.asciidoc
Outdated
Show resolved
Hide resolved
@alexanderfle Apologies, I didn't mean to mark this as ready to review. My finger slipped, and I can't find a way to mark the PR as a draft again. |
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
Signed-off-by: Alexander Flegontov <alexander.flegontov@intel.com>
@Pennycook , @gmlueck , @romanovvlad, are there any other comments on the current version of the document? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted one formatting issue during another read through. I think this can be opened for review.
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
…_QUEUE_EVENTS.asciidoc Co-authored-by: John Pennycook <john.pennycook@intel.com>
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
@gmlueck , btw, Should we add to the document that Level Zero will temporarily work without optimization? Since Level Zero support is required to be able to not create a low-level event. |
This depends. Do we plan to implement the Level Zero support at the same time that we implement the DPC++ support? If so, there is no need to document that limitation because it won't exist when this extension is implemented. |
Ok, I expect DPC ++ support to be added faster than Level Zero plugin support. So I'll add a few words about that. |
sycl/doc/extensions/DiscardQueueEvents/SYCL_EXT_ONEAPI_DISCARD_QUEUE_EVENTS.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…_QUEUE_EVENTS.asciidoc Co-authored-by: John Pennycook <john.pennycook@intel.com>
Review documentation in #4922
See extension document for SYCL describing discard queue events behaviour