Skip to content

[Driver][SYCL] Allow -Xsycl-target-frontend= to accept triple aliases #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qichaogu
Copy link
Contributor

@qichaogu qichaogu commented Nov 1, 2021

-Xsycl-target-backend= is allowed to use triple aliases,
e.g. spir64_x86_64 -> spir64_x86_64-unknown-unknown.
Allow -Xsycl-target-frontend= to accept triple aliases too.

Signed-off-by: Qichao Gu qichao.gu@intel.com

Signed-off-by: Qichao Gu <qichao.gu@intel.com>
@qichaogu
Copy link
Contributor Author

qichaogu commented Nov 1, 2021

FYI - #3984 allows -Xsycl-target-backend= to use triple aliases.

Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the same be done for -Xsycl-target-linker in scope of this PR?

@qichaogu
Copy link
Contributor Author

qichaogu commented Nov 1, 2021

Can the same be done for -Xsycl-target-linker in scope of this PR?

It's also covered by #3984.

Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for a testing nuance

Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@qichaogu
Copy link
Contributor Author

qichaogu commented Nov 8, 2021

@intel/llvm-gatekeepers Could you help merge?

@dm-vodopyanov dm-vodopyanov merged commit 7fa0569 into intel:sycl Nov 8, 2021
@qichaogu qichaogu deleted the Xsycl-target-frontend-triple-aliases branch November 9, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants