[Driver][SYCL] Allow for known aliases to be used for -fsycl-targets #3984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using -fsycl-targets, usage is clumsy as we want the full triple to be used: spir64-unknown-unknown-sycldevice Allow for just the 'arch' to be specified, which will be expanded: spir64 -> spir64-unknown-unknown-sycldevice spir64_gen -> spir64_gen-unknown-unknown-sycldevice spir64_fpga -> spir64_fpga-unknown-unknown-sycldevice spir64_x86_64 -> spir64_x86_64-unknown-unknown-sycldevice
|
@mdtoguchi, I suggest we update out documentation together with this change. Currently Getting Started Guide and User Manual suggest using full triple. |
pvchupin
previously approved these changes
Jun 24, 2021
AGindinson
previously approved these changes
Jun 25, 2021
AGindinson
reviewed
Jun 25, 2021
bader
approved these changes
Jun 27, 2021
AGindinson
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using -fsycl-targets, usage is clumsy as we want the full triple to
be used: spir64-unknown-unknown-sycldevice
Allow for just the 'arch' to be specified, which will be expanded:
spir64 -> spir64-unknown-unknown-sycldevice
spir64_gen -> spir64_gen-unknown-unknown-sycldevice
spir64_fpga -> spir64_fpga-unknown-unknown-sycldevice
spir64_x86_64 -> spir64_x86_64-unknown-unknown-sycldevice