-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Return support for compilation with C++14 back #3802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Return support for compilation with C++14 back #3802
Conversation
…ompat.cpp (intel#3463)" This reverts commit 815b43b.
Probably it would be nice to add a warning saying that some features are disabled in case of compilation with c++14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please, add a warning and fix pre-commit failures. |
Hm, not sure how to add a warning message in headers. Pragma warning is not reported as SYCL headers are considered as system ones. Any thoughts? Should we do this in the driver? |
+@AaronBallman |
Some compilers support |
Trying to add a warning here: #4303 (comment) |
The patch enables ability to compile a SYCL application that doesn't use certain
features (sycl::span, SYCL2020 specialization constants) with -std=c++14 option
by guarding code which uses C++17 feature with macro.