Skip to content

[SYCL] Remove check with -std=c++14 from basic_tests/stdcpp_compat.cpp #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2021
Merged

[SYCL] Remove check with -std=c++14 from basic_tests/stdcpp_compat.cpp #3463

merged 2 commits into from
Apr 1, 2021

Conversation

dm-vodopyanov
Copy link
Contributor

This patch removes check with -std=c++14 from
basic_tests/stdcpp_compat.cpp test because DPC++ headers now have C++17
features

This patch removes check with -std=c++14 from
basic_tests/stdcpp_compat.cpp test because DPC++ headers now have C++17
features
@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner April 1, 2021 09:44
@dm-vodopyanov dm-vodopyanov requested a review from v-klochkov April 1, 2021 09:44
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth adding to the documentation that -std=c++14 is not supported by DPC++.
Please, open a separate PR for documentation update.

@bader bader merged commit 815b43b into intel:sycl Apr 1, 2021
@bader
Copy link
Contributor

bader commented Apr 1, 2021

For other reviewers: this is NFC patch and it fixes CI pre- and post-commit checks, so I merged w/o code owner approval.
Please, feel free to comment this PR anyway and Dmitry will apply them in follow-up pull request.

romanovvlad added a commit to romanovvlad/llvm that referenced this pull request May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants