Skip to content

[SYCL] Add all devicelib function to builtins #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2021
Merged

[SYCL] Add all devicelib function to builtins #3472

merged 3 commits into from
Apr 8, 2021

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Apr 2, 2021

Signed-off-by: gejin ge.jin@intel.com

@jinge90 jinge90 requested a review from a team as a code owner April 2, 2021 03:37
@jinge90 jinge90 requested a review from s-kanaev April 2, 2021 03:37
jinge90 added 3 commits April 2, 2021 11:44
@jinge90
Add all devicelib function to builtins
325f739 
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
add c99 complex API to builtins
48da54e 
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
c99 complex API is not available in MS
ae155db 
Signed-off-by: gejin <ge.jin@intel.com>
s-kanaev
s-kanaev reviewed Apr 2, 2021
View reviewed changes
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinge90 , is there anything else expected?

@jinge90
Copy link
Contributor Author

jinge90 commented Apr 2, 2021

@jinge90 , is there anything else expected?

Hi, @s-kanaev
For now, I think all functions are added. We find adding "-fno-builtin" will lead to failures for some cmath and complex tests. This PR aims to fix this problem and we will add "-fno-builtin" for DeviceLib tests.
I added "WIP" because I want to do some local test with "-fno-builtin" for DeviceLib, if no failures found, I will remove "WIP".
Thanks very much.

@jinge90 jinge90 changed the title [SYCL][WIP] Add all devicelib function to builtins [SYCL] Add all devicelib function to builtins Apr 7, 2021
@jinge90 jinge90 mentioned this pull request Apr 7, 2021
Merged
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 7, 2021

Hi, @s-kanaev
Local tests didn't report any failure, we can merge this patch now.
Thanks very much.

@bader bader merged commit 7d17aa7 into intel:sycl Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-kanaev s-kanaev s-kanaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinge90 @s-kanaev @bader