Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Add lit test for integer math function abs, labs, llabs #184

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

haonanya
Copy link

@haonanya haonanya commented Mar 16, 2021

Signed-off-by: haonanya haonan.yang@intel.com
This PR aims to add lit test for intel/llvm#3364

Signed-off-by: haonanya <haonan.yang@intel.com>
@haonanya haonanya requested review from jinge90 and s-kanaev March 16, 2021 08:47
vzakhari
vzakhari previously approved these changes Mar 17, 2021
@vladimirlaz
Copy link

The tests is passing before submission of intel/llvm#3364. I expected that the test should fail until the device library change is submitted.

@jinge90
Copy link

jinge90 commented Mar 19, 2021

The tests is passing before submission of intel/llvm#3364. I expected that the test should fail until the device library change is submitted.

Hi, @vladimirlaz
You are correct, this test should fail without compiler device library abs support. The reason why pass here is in device compilation, FE will convert function call "abs" to llvm.abs intrinsic and llvm-spirv can support this intrinsic now.
We will add "-fno-builtin" to the math test and then all math function call will reside in device code and device library will support them.
Thanks very much.

@jinge90
Copy link

jinge90 commented Mar 23, 2021

@haonanya
Could you add "-fno-builtin" to the building command?

Copy link

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haonanya
Could you add "-fno-builtin" to the building command?

@haonanya
Copy link
Author

Hi, @vladimirlaz. Sorry for late reply. There are some compiling issues when added "-fno-builtin" to the building command in Windows, we are looking into this issue.
Thanks very much.

Signed-off-by: haonanya <haonan.yang@intel.com>
@jinge90
Copy link

jinge90 commented Apr 7, 2021

Hi, @vladimirlaz
This test are expected to work when intel/llvm#3472 is merged.
Thanks very much.

@vladimirlaz
Copy link

The failures below do not correlate with the PR:

  • SYCL :: Regression/implicit_offset_debug_info.cpp
  • SYCL :: USM/pointer_query.cpp

@vladimirlaz vladimirlaz requested a review from vzakhari April 24, 2021 09:42
@vladimirlaz vladimirlaz merged commit a810ac1 into intel:intel Apr 28, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants