Skip to content

[SYCL][Driver] Enable splitting of ESIMD code in sycl-post-link #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2021
Merged

[SYCL][Driver] Enable splitting of ESIMD code in sycl-post-link #3086

merged 3 commits into from
Jan 30, 2021

Conversation

DenisBakhvalov
Copy link
Contributor

We split ESIMD and SYCL code by default unless -fintelfpga
is provided.

@DenisBakhvalov
[SYCL][Driver] Enable splitting of ESIMD code in sycl-post-link
b9f1777 
We split ESIMD and SYCL code by default unless -fintelfpga
is provided.
@DenisBakhvalov DenisBakhvalov mentioned this pull request Jan 24, 2021
Closed
AGindinson
AGindinson reviewed Jan 25, 2021
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the expected/desired behavior for separate ESIMD split when -fsycl-device-code-split=off is used? Is this going to be encapsulated by the post-link tool, or should some driver-level diagnostics be provided?

@DenisBakhvalov
Copy link
Contributor Author

What is the expected/desired behavior for separate ESIMD split when -fsycl-device-code-split=off is used? Is this going to be encapsulated by the post-link tool, or should some driver-level diagnostics be provided?

This is fine. Both -fsycl-esimd-split and -fsycl-device-code-split options can coexist together. When the latter option is off, the device code will be split into SYCL and ESIMD parts, but no further splitting will be done. So, there is no interference between the two options. See the corresponding PR with sycl-post-link implementation: #3044.

@bader bader requested a review from AGindinson January 26, 2021 09:24
kbobrovs
kbobrovs reviewed Jan 26, 2021
View reviewed changes
AGindinson
AGindinson reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I'd defer the final approval to @mdtoguchi, especially since a new option is being added.

kbobrovs
kbobrovs previously approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we really need @mdtoguchi to take a look at this too.

@DenisBakhvalov
Copy link
Contributor Author

@mdtoguchi is on vacation. @hchilama, please review on Mike's behalf.

kbobrovs
kbobrovs reviewed Jan 29, 2021
View reviewed changes
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DenisBakhvalov - JFYI, looks like this unrelated change somehow sneaked into your patch

@kbobrovs
Copy link
Contributor

@DenisBakhvalov - JFYI, looks like this unrelated change somehow sneaked into your patch

Please disregard. This - 9afe27f - is a merge/rebase I guess. Does not show up in the patch actually.

hchilama
hchilama approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@hchilama hchilama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbobrovs kbobrovs merged commit c8fa5b2 into intel:sycl Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbobrovs kbobrovs kbobrovs approved these changes

@AGindinson AGindinson AGindinson approved these changes

@hchilama hchilama hchilama approved these changes

@mdtoguchi mdtoguchi Awaiting requested review from mdtoguchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DenisBakhvalov @kbobrovs @AGindinson @hchilama