-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Add -vc-codegen compile option for ESIMD images #3074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. NOTE: the pi changes are already a part of #3072
NOTE: The current PR will not have any immediate impact on functionality since we guard splitting SYCL and ESIMD code in sycl-post-link tool under an option ( @kbobrovs, @romanovvlad, @bader, My current plan is to test it using |
OK with me. |
a482ba0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. but the identifier might change if we rename SYCL/Is ESIMD Image
category change.
This change is a part of 3 patches:
Patch (1/3): [new property] #3072
Patch (2/3): [sycl-post-link] #3073
Patch (3/3): [DPCPP RT] this PR
Please review only patch f8fdd3c