[clang-offload-bundler] Add new unbundling mode 'a' for archives #2840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for unbundling archives into archives under a new file type 'a'. Input file for this mode is expected to be an archive with fat object files and outputs (one per offload target) will be archives with extracted device specific parts from the input's objects. Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
sndmitriev
requested review from
AGindinson,
elizabethandrews,
Fznamznon,
mdtoguchi and
premanandrao
as code owners
bader
previously approved these changes
Dec 1, 2020
No, this is a different change. We have added support for unbundling archives in sycl branch long time ago, but we did not have ‘a’ mode where the extracted target objects are expected to be packed back into archives. So, now I am just adding this missing part. |
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
kbobrovs
reviewed
Dec 2, 2020
kbobrovs
approved these changes
Dec 2, 2020
|
I believe LIT fails in checkin testing are not related to these changes. The original patch has successfully passed testing, and LIT failures appeared after correcting typo in comments. |
|
I think I have addressed all comments now. Is there anything else that need to be done to get this merged? |
|
"Waiting on code owner review from AGindinson and/or mdtoguchi." |
AGindinson
reviewed
Dec 3, 2020
bader
changed the title
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Jul 5, 2021
Reference commit: ad05778 [clang-offload-bundler] Add new unbundling mode 'a' for archives (intel#2840) Also added an override keyword that was missed during eda76af. CONFLICT (content): Merge conflict in clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp CONFLICT (content): Merge conflict in clang/test/Driver/clang-offload-bundler.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for unbundling archives into archives under a new
file type 'a'. Input file for this mode is expected to be an archive with
fat object files and outputs (one per offload target) will be archives
with extracted device specific parts from the input's objects.
Signed-off-by: Sergey Dmitriev serguei.n.dmitriev@intel.com