Skip to content

[SYCL] Make Level-Zero events visible on the host #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2020
Merged

[SYCL] Make Level-Zero events visible on the host #2576

merged 1 commit into from
Oct 1, 2020

Conversation

smaslov-intel
Copy link
Contributor

Make all events visible on the host, since we are waiting for many of them there.
Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com

@smaslov-intel
[SYCL] explicitly ask Leve-Zero events to be visible on the host
a45e33d 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
romanovvlad
romanovvlad requested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test?

@smaslov-intel
Copy link
Contributor Author

Could you please add a test?

As it is often the case with the plugin, it is hard to make a dedicated test, especially LIT test.
Currently this change is a no-op since driver's default assumption is just what I've made explicit here.
Without this change when the driver is really looking at this flag, every benchmark would actually fail to run, so we have the tests.

@romanovvlad
Copy link
Contributor

As it is often the case with the plugin, it is hard to make a dedicated test, especially LIT test.
Please, take a look at how similar tests are written for the CUDA plugin:

https://github.com/intel/llvm/tree/sycl/sycl/unittests/pi/cuda

Currently this change is a no-op since driver's default assumption is just what I've made explicit here.

Ok, agree.

@bader bader changed the title [SYCL] explicitly ask Level-Zero events to be visible on the host [SYCL] Make Level-Zero events visible on the host Oct 1, 2020
@bader bader merged commit b84d49b into intel:sycl Oct 1, 2020
@bader
Copy link
Contributor

bader commented Oct 1, 2020

Updated commit message to:

"[SYCL] Make Level-Zero events visible on the host (#2576)

The runtime is waiting for many of them there.

Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com"

alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Oct 5, 2020
Merge remote-tracking branch 'upstream/sycl' into global_constructors…
e4b7866 
…_wrapper

* upstream/sycl: (1021 commits)
  [SYCL] Enable async_work_group_copy for scalar and vector bool types (intel#2582)
  [SYCL] Fix element type in handler::copy (intel#2590)
  [NFC][SYCL] Remove unnecessary if condition (intel#2585)
  [SYCL][NFC] Fix SYCL lit test execution on a system w/o GPU (intel#2584)
  [SYCL] Add error handling for non-uniform work group size case (intel#2569)
  [SYCL][ESIMD] Preserve undef initializer for globals in ESIMDLowerVecArg pass (intel#2555)
  [SYCL] Make Level-Zero events visible on the host (intel#2576)
  [Driver][SYCL][NFC] Add help information for -Wno-sycl-strict (intel#2570)
  [SYCL] Relax test to work in Win32 environment. (intel#2580)
  [SYCL] Emit suppressed warnings from SYCL headers (intel#2575)
  [SYCL][NFC] Cover more classes with ABI tests (intel#2577)
  [SYCL][ESIMD] Update ESIMD tests and add raw send support. (intel#2482)
  [SYCL] Make ESIMD on-device tests require linux,gpu,opencl. (intel#2560)
  [SYCL] Release commands with no dependencies after they're enqueued (intel#2492)
  [SYCL] Add multi-device and multi-platform support for SYCL_DEVICE_ALLOWLIST  (intel#2483)
  [SYCL] Try to enqueue host command depencies (intel#2561)
  [SYCL][ESIMD][NFC] Align namespace name with the spec guidelines (intel#2573)
  [SYCL][NFC] Add class layout ABI tests for memory objects (intel#2559)
  [SYCL] Change adress space for global variables (intel#2534)
  [NFC][SYCL] Fix comment. (intel#2541)
  ...
iclsrc pushed a commit that referenced this pull request May 23, 2024
@wenju-he @sys-ce-bb
Add ret type to convert-SampledImage builtin name (#2576)
99c391b 
Similar as ConvertHandleToImageINTEL, ConvertHandleToSampledImageINTEL
builtin may have the same argument type but different return types.
So we need to add ret type as name suffix when translating to LLVM IR.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@04972917552b08e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanovvlad romanovvlad romanovvlad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smaslov-intel @romanovvlad @bader