Skip to content

[Driver][SYCL][NFC] Add help information for -Wno-sycl-strict #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2020
Merged

[Driver][SYCL][NFC] Add help information for -Wno-sycl-strict #2570

merged 1 commit into from
Oct 1, 2020

Conversation

mdtoguchi
Copy link
Contributor

-Wno-sycl-strict is used in the compatibility tool user guide. Add to the
help to provide additional (if minimal) information.

@mdtoguchi
[Driver][SYCL][NFC] Add help information for -Wno-sycl-strict
537724b 
-Wno-sycl-strict is used in the compatibility tool user guide.  Add to the
help to provide additional (if minimal) information.
AGindinson
AGindinson reviewed Sep 30, 2020
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify: is the option supposed to have any effect on DPC++ compilations at some point? Or is this more of a convenience thing so that DPCT users can get the help info from both "major" tools?

@mdtoguchi
Copy link
Contributor Author

Just to clarify: is the option supposed to have any effect on DPC++ compilations at some point? Or is this more of a convenience thing so that DPCT users can get the help info from both "major" tools?

The intention of this is to provide help information. Just a convenience thing as folks see the option in various guides and go looking for information.

@AGindinson
Copy link
Contributor

The intention of this is to provide help information. Just a convenience thing as folks see the option in various guides and go looking for information.

It's just that having this exposed by DPC++ compiler might mislead the users as to whether the option can affect the DPC++ compilation. Can this be added on the DPCT side instead?

@AGindinson
Copy link
Contributor

It's just that having this exposed by DPC++ compiler might mislead the users as to whether the option can affect the DPC++ compilation. Can this be added on the DPCT side instead?

Never mind, I'm seeing it's a regular compiler option configuration now.

@bader bader merged commit 6ba2260 into intel:sycl Oct 1, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Oct 5, 2020
Merge remote-tracking branch 'upstream/sycl' into global_constructors…
e4b7866 
…_wrapper

* upstream/sycl: (1021 commits)
  [SYCL] Enable async_work_group_copy for scalar and vector bool types (intel#2582)
  [SYCL] Fix element type in handler::copy (intel#2590)
  [NFC][SYCL] Remove unnecessary if condition (intel#2585)
  [SYCL][NFC] Fix SYCL lit test execution on a system w/o GPU (intel#2584)
  [SYCL] Add error handling for non-uniform work group size case (intel#2569)
  [SYCL][ESIMD] Preserve undef initializer for globals in ESIMDLowerVecArg pass (intel#2555)
  [SYCL] Make Level-Zero events visible on the host (intel#2576)
  [Driver][SYCL][NFC] Add help information for -Wno-sycl-strict (intel#2570)
  [SYCL] Relax test to work in Win32 environment. (intel#2580)
  [SYCL] Emit suppressed warnings from SYCL headers (intel#2575)
  [SYCL][NFC] Cover more classes with ABI tests (intel#2577)
  [SYCL][ESIMD] Update ESIMD tests and add raw send support. (intel#2482)
  [SYCL] Make ESIMD on-device tests require linux,gpu,opencl. (intel#2560)
  [SYCL] Release commands with no dependencies after they're enqueued (intel#2492)
  [SYCL] Add multi-device and multi-platform support for SYCL_DEVICE_ALLOWLIST  (intel#2483)
  [SYCL] Try to enqueue host command depencies (intel#2561)
  [SYCL][ESIMD][NFC] Align namespace name with the spec guidelines (intel#2573)
  [SYCL][NFC] Add class layout ABI tests for memory objects (intel#2559)
  [SYCL] Change adress space for global variables (intel#2534)
  [NFC][SYCL] Fix comment. (intel#2541)
  ...
kbenzie pushed a commit to kbenzie/intel-llvm that referenced this pull request Feb 17, 2025
@isaacault
Merge pull request intel#2570 from isaacault/copy_to_move
af4ab49 
Fix Coverity COPY_INSTEAD_OF_MOVE defects.
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
@isaacault
Merge pull request #2570 from isaacault/copy_to_move
d84880a 
Fix Coverity COPY_INSTEAD_OF_MOVE defects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGindinson AGindinson AGindinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdtoguchi @AGindinson @bader