Skip to content

[SYCL][DebugInfo] Reinstate source locations for some kernel instruct… #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

stevemerr
Copy link
Contributor

…ions

Now that the source location of the kernel caller function is being assigned to the initialization code in the kernel body, stop clearing the source locations for some other instructions (e.g. call to operator() and the return instruction).

Signed-off-by: Steve Merritt steve.merritt@intel.com

…ions

Now that the source location of the kernel caller function is being assigned to the initialization code in the kernel body, stop clearing the source locations for some other instructions (e.g. call to operator() and the return instruction).

Signed-off-by: Steve Merritt <steve.merritt@intel.com>
premanandrao
premanandrao previously approved these changes Sep 23, 2020
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

Copy link
Contributor

@bwyma bwyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bader
Copy link
Contributor

bader commented Sep 24, 2020

@stevemerr, please, file a tracker for "LLVM_SPIRV :: capability-arbitrary-precision-integers.ll" failure. I don't think it's related to this PR, so I'll merge it.
Tagging @AlexeySotkin.

@bader bader merged commit 4d814bf into intel:sycl Sep 24, 2020
@stevemerr
Copy link
Contributor Author

stevemerr commented Sep 24, 2020

@bader @AlexeySotkin - I think the failure was already reported. There is still an open PR: #2454

@stevemerr stevemerr deleted the kernelsourcelocations branch September 24, 2020 14:37
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Sep 29, 2020
…_wrapper

* upstream/sycl: (1533 commits)
  [SYCL] XFAIL sub_group shuffle tests on GPU
  [SYCL] Add support for L0 loader validation layer (intel#2520)
  [NFC][LIT] Temporary disable function pointers as they hang on L0 (intel#2544)
  [SYCL] use release version of OpenCL ICD loader
  [SYCL] Improve testing of host-task (intel#2540)
  Revert 1291215
  [SYCL] Fix warning caused by [[nodiscard]] attribute (intel#2545)
  [SYCL] Workaround windows build failure
  [SYCL] Remove kernel_signature_start from int header (intel#2537)
  [SYCL] Fix ABI tests in post-commit (intel#2539)
  [SYCL][DOC] Update C-CXX-StandardLibrary doc to align with latest status (intel#2529)
  [SYCL][NFC] Fix static code analysis concerns (intel#2531)
  [SYCL][NFC] Improve testing for accessor_property_list (intel#2532)
  [SYCL] Avoid overuse of CPU on wait read-write lock loop (intel#2525)
  [SYCL] Implement no-decomposition for kernel types that don't need it. (intel#2477)
  [SYCL] Add group algorithm constraints (intel#2462)
  [BuildBot] Uplift Windows GPU RT from 8673 to 8778 (intel#2533)
  [SYCL][LIT][NFC] Extend ABI test suite (intel#2522)
  [SYCL][DebugInfo] Reinstate source locations for some kernel instructions (intel#2527)
  [SYCL][NFC] Replace the deprecated VectorType::getNumElements() (intel#2524)
  ...
iclsrc pushed a commit that referenced this pull request Jul 5, 2024
kbenzie pushed a commit to kbenzie/intel-llvm that referenced this pull request Feb 17, 2025
Wrap urEventSetCallback when ran through loader
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
Wrap urEventSetCallback when ran through loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants