Skip to content

[SYCL] Optionally enable STL assertions #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 19, 2020

Conversation

alexbatashev
Copy link
Contributor

This is a followup for #2310. The patch adds an option to enable assertions in standard containers and algorithms (such as bounds and null pointer checks) both in SYCL runtime and tests. These checks are also enabled in post-commit to catch possible regressions.

@alexbatashev alexbatashev requested review from bader and a team as code owners August 17, 2020 10:18
@alexbatashev alexbatashev requested a review from rbegam August 17, 2020 10:18
@bader
Copy link
Contributor

bader commented Aug 17, 2020

How about enable STL assertion with LLVM_ENABLE_ASSERTIONS and add an option to disable them?

@alexbatashev
Copy link
Contributor Author

How about enable STL assertion with LLVM_ENABLE_ASSERTIONS and add an option to disable them?

Done

@alexbatashev
Copy link
Contributor Author

@intel/llvm-reviewers-runtime ping

@bader bader merged commit ec2ec99 into intel:sycl Aug 19, 2020
@alexbatashev alexbatashev deleted the enable_stl_assertions branch August 19, 2020 16:14
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
Index into property array in urDevicePartition for OpenCL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants