[SYCL] Fix UB in memory manager #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If vector is empty, accessing any of its elements is UB. Use `data()` method to get pointer to vector data. Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
sergey-semenov
approved these changes
Aug 13, 2020
|
Is a bug fix |
bader
changed the title
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Aug 17, 2020
This reverts commit 4ff2eee.
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Aug 17, 2020
This reverts commit 1cb5670.
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Aug 17, 2020
This reverts commit 1ee1718.
bader
pushed a commit
that referenced
this pull request
Aug 19, 2020
This is a followup for #2310. The patch adds an option to enable assertions in standard containers and algorithms (such as bounds and null pointer checks) both in SYCL runtime and tests. These checks are also enabled in post-commit to catch possible regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If vector is empty, accessing any of its elements is UB. Use
data()method to get pointer to vector data.
Signed-off-by: Alexander Batashev alexander.batashev@intel.com