[SYCL] Add runtime support for device code argument elimination #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the byte array type properties. Register the new kernel parameter optimization properties while adding binary images in the program manager. This information is then used while setting kernel arguments to skip over the eliminated ones. Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
sergey-semenov
requested review from
kbobrovs,
smaslov-intel and
a team
as code owners
|
TBD: add tests |
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
kbobrovs
previously requested changes
Aug 14, 2020
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
* replace unsigned char with std::uint8_t * replace the use of vector with a custom wrapper to avoid unnecessary copying * remove inappropriate use of CHAR_BIT * add some TODO's for potential improvements * fix a test case by allowing unset arguments (as long as they are set on the user side) Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
romanovvlad
approved these changes
Aug 17, 2020
smaslov-intel
approved these changes
Aug 17, 2020
romanovvlad
dismissed
kbobrovs’s stale review
The comments are resolved. Feel free to write more comments, we will resolved them in a separate PR.
jsji
pushed a commit
that referenced
this pull request
Feb 1, 2024
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[SYCL] Add -foffload-fp32-prec-[div/sqrt] FE option handling in JIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the byte array type properties. Register the new kernel
parameter optimization properties while adding binary images in the
program manager. This information is then used while setting kernel
arguments to skip over the eliminated ones.
Signed-off-by: Sergey Semenov sergey.semenov@intel.com