Skip to content

[libclc] Drop CL_3_0_EXTENSIONS override; fix NVPTX image features #21119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenju-he wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[libclc] Drop CL_3_0_EXTENSIONS override; fix NVPTX image features #21119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang/lib/Basic/Targets/NVPTX.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ class LLVM_LIBRARY_VISIBILITY NVPTXTargetInfo : public TargetInfo {
Opts["cl_khr_int64_extended_atomics"] = true;
Opts["cl_khr_fp16"] = true;
Opts["cl_khr_3d_image_writes"] = true;
Opts["__opencl_c_3d_image_writes"] = true;
Opts["__opencl_c_images"] = true;

Opts["__opencl_c_generic_address_space"] = true;
}
Expand Down
8 changes: 0 additions & 8 deletions libclc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,14 +514,6 @@ foreach( t ${LIBCLC_TARGETS_TO_BUILD} )
# Build for OpenCL 3.0 independently of the target or device.
list( APPEND build_flags -cl-std=CL3.0 )

# OpenCL 3.0 extensions
string(CONCAT CL_3_0_EXTENSIONS
"-cl-ext="
"+__opencl_c_3d_image_writes,"
"+__opencl_c_images,"
"+cl_khr_3d_image_writes")
list( APPEND build_flags "-Xclang" ${CL_3_0_EXTENSIONS} )

# Add platform specific flags
if(WIN32)
list(APPEND build_flags -D_WIN32)
Expand Down