[libclc] Drop CL_3_0_EXTENSIONS override; fix NVPTX image features #21119
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFC for libclc and libspirv. Remove the unconditional OpenCL 3.0 extension override from libclc. They should be enabled per-target, not globally. When enabling cl_khr_3d_image_writes, NVPTX should also enable dependent __opencl_c_3d_image_writes and __opencl_c_images. cl_khr_3d_image_writes and __opencl_c_3d_image_writes can't have different values. Fix locally since upstream PR llvm/llvm-project#143331 is pending.
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
approved these changes
Jan 26, 2026
Fznamznon
reviewed
Jan 26, 2026
Contributor
Fznamznon
left a comment
Fznamznon
left a comment
There was a problem hiding this comment.
If that is NFC, should we ping the upstream PR better? Community allows pinging once a week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFC for libclc and libspirv.
Remove the unconditional OpenCL 3.0 extension override from libclc. They should be enabled per-target, not globally.
When enabling cl_khr_3d_image_writes, NVPTX should also enable dependent __opencl_c_3d_image_writes and __opencl_c_images. cl_khr_3d_image_writes and __opencl_c_3d_image_writes can't have different values. Fix locally since upstream PR llvm/llvm-project#143331 is pending.