[SYCL][Driver] Emit unused argument warning for -fno-libspirv #19135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2025
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
from
717300b to
df0bc40
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-unused-argument
branch
from
eb713e6 to
8badf3c
Compare
mdtoguchi
approved these changes
Jun 25, 2025
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
from
df0bc40 to
491016c
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-unused-argument
branch
from
8badf3c to
db2c9d8
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
from
491016c to
c1b5a53
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-unused-argument
branch
from
db2c9d8 to
eac8168
Compare
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 27, 2025
) <!-- start git-machete generated --> # Based on PR #18956 ## Tree of downstream PRs as of 2025-06-25 * **PR #19130 (THIS ONE)** * PR #19131 * PR #19134 * PR #19135 * PR #19136 <!-- end git-machete generated --> In the next commits I'd like to refactor and fix SYCL libspirv linking. This adds a few tests to cover the current behavior. Some of it is buggy, and not consistent between NVPTX and AMDGPU, it will be improved in the next commits.
Maetveis
force-pushed
the
review/Maetveis/libspirv-unused-argument
branch
from
eac8168 to
11e238c
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
from
c1b5a53 to
63704bf
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-unused-argument
branch
from
11e238c to
d5440ef
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
from
63704bf to
c0793c1
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-unused-argument
branch
from
d5440ef to
e5c3890
Compare
bader
pushed a commit
that referenced
this pull request
Jun 27, 2025
<!-- start git-machete generated --> # Based on PR #19130 ## Chain of upstream PRs & tree of downstream PRs as of 2025-06-25 * PR #19130 * **PR #19131 (THIS ONE)** * PR #19134 * PR #19135 * PR #19136 <!-- end git-machete generated --> Move the logic for finding and linking libspirv into SYCLInstallationDetector. This code was basically duplicated between the CUDA and HIP toolchains, and was also present in the Driver sources. This is NFC, aside from the fact that the code in the HIP toolchain lacked the special handling for the `-###` driver option present in the other two places.
Previously the `-fno-libspirv` option was not warned about when there was no SYCL compilation. Remove the explicit target check for the targets that support `-fno-libspirv` and instead rely on each target to emit appropriate warnings when its used. This commit slightly degrades diagnostic quality, from "ignoring '-fno-sycl-libspirv' option as it is not currently supported for target" to "argument unused during compilation: '-fno-sycl-libspirv'" , but I believe this is acceptable as it allows to remove the list of targets that support the option from the driver. Additionally, now if the user mixes targets that support and do not support `-fno-libspirv` in the same compilation, they will not get warnings that are not actionable.
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
from
c0793c1 to
3339a77
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-unused-argument
branch
from
e5c3890 to
0bb5db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #19134
Chain of upstream PRs & tree of downstream PRs as of 2025-06-25
PR [SYCL][Driver] Improve SYCL libspirv linking test coverage (NFC) #19130
PR [SYCL][Driver] Deduplicate libspirv logic #19131
PR [SYCL][Driver] Base libspirv path on sycl install candidates #19134
PR [SYCL][Driver] Emit unused argument warning for -fno-libspirv #19135 (THIS ONE)
-fsycl-device-onlymode #19136Previously the
-fno-libspirvoption was not warned about when therewas no SYCL compilation.
Remove the explicit target check for the targets that support
-fno-libspirvand instead rely on each target to emit appropriatewarnings when its used.
This commit slightly degrades diagnostic quality, from
"ignoring '-fno-sycl-libspirv' option as it is not currently supported for target"
to
"argument unused during compilation: '-fno-sycl-libspirv'"
, but I believe this is acceptable as it allows to remove the list
of targets that support the option from the driver. Additionally,
now if the user mixes targets that support and do not support
-fno-libspirvin the same compilation, they will not get warningsthat are not actionable.