[SYCL][Driver] Base libspirv path on sycl install candidates #19134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2025
Maetveis
force-pushed
the
review/Maetveis/deduplicate-libspirv-logic
branch
from
f0a2209 to
d04b05d
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
from
717300b to
df0bc40
Compare
mdtoguchi
approved these changes
Jun 25, 2025
Maetveis
force-pushed
the
review/Maetveis/deduplicate-libspirv-logic
branch
from
d04b05d to
830c773
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
2 times, most recently
from
491016c to
c1b5a53
Compare
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 27, 2025
) <!-- start git-machete generated --> # Based on PR #18956 ## Tree of downstream PRs as of 2025-06-25 * **PR #19130 (THIS ONE)** * PR #19131 * PR #19134 * PR #19135 * PR #19136 <!-- end git-machete generated --> In the next commits I'd like to refactor and fix SYCL libspirv linking. This adds a few tests to cover the current behavior. Some of it is buggy, and not consistent between NVPTX and AMDGPU, it will be improved in the next commits.
Maetveis
force-pushed
the
review/Maetveis/deduplicate-libspirv-logic
branch
from
d183788 to
f08825e
Compare
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
2 times, most recently
from
63704bf to
c0793c1
Compare
bader
pushed a commit
that referenced
this pull request
Jun 27, 2025
<!-- start git-machete generated --> # Based on PR #19130 ## Chain of upstream PRs & tree of downstream PRs as of 2025-06-25 * PR #19130 * **PR #19131 (THIS ONE)** * PR #19134 * PR #19135 * PR #19136 <!-- end git-machete generated --> Move the logic for finding and linking libspirv into SYCLInstallationDetector. This code was basically duplicated between the CUDA and HIP toolchains, and was also present in the Driver sources. This is NFC, aside from the fact that the code in the HIP toolchain lacked the special handling for the `-###` driver option present in the other two places.
Base automatically changed from
review/Maetveis/deduplicate-libspirv-logic
to
sycl
June 27, 2025 15:15
|
@Maetveis, please, resolve conflicts. |
... instead of the resource directory. This matches the behaviour of SYCL device libraries. The resource directory has nothing to do with libspirv, and it might be changed by the `-resource-dir` option, which would lead us to not find it.
Maetveis
force-pushed
the
review/Maetveis/libspirv-path-install-dir
branch
from
c0793c1 to
3339a77
Compare
|
These unexpected passes don't seem to be related. @intel/dpcpp-devops-reviewers, any GPU driver updates recently? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #19131
Chain of upstream PRs & tree of downstream PRs as of 2025-06-25
PR [SYCL][Driver] Improve SYCL libspirv linking test coverage (NFC) #19130
PR [SYCL][Driver] Deduplicate libspirv logic #19131
PR [SYCL][Driver] Base libspirv path on sycl install candidates #19134 (THIS ONE)
PR [SYCL][Driver] Emit unused argument warning for -fno-libspirv #19135
-fsycl-device-onlymode #19136... instead of the resource directory. This matches the behaviour of
SYCL device libraries. The resource directory has nothing to do with
libspirv, and it might be changed by the
-resource-diroption, whichwould lead us to not find it.