-
Notifications
You must be signed in to change notification settings - Fork 769
[NFC][SYCL] enable_shared_from_this
for queue_impl
#18715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aelovikov-intel
merged 2 commits into
intel:sycl
from
aelovikov-intel:queue-impl-shared-from-this
May 30, 2025
Merged
[NFC][SYCL] enable_shared_from_this
for queue_impl
#18715
aelovikov-intel
merged 2 commits into
intel:sycl
from
aelovikov-intel:queue-impl-shared-from-this
May 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to pass an ugly `Self` in multiple methods after this. Further simplifications enabled by this change are left for subsequent PRs.
0586293
to
18cebb5
Compare
uditagarwal97
approved these changes
May 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@reble , @intel/sycl-graphs-reviewers , ping |
EwanC
approved these changes
May 30, 2025
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
May 30, 2025
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 3, 2025
…ared` And once that is guaranteed, inherit it from `std::enable_shared_from_this`. Further simplifications based on `[shared|weak]_from_this` are left to subsequent PRs. Earlier related PRs: intel#18715 same for `queue_impl` intel#18227 same for `device_impl` intel#18141 similar for `platform_impl`
aelovikov-intel
added a commit
that referenced
this pull request
Jun 4, 2025
…ared` (#18795) And once that is guaranteed, inherit it from `std::enable_shared_from_this`. Further simplifications based on `[shared|weak]_from_this` are left to subsequent PRs. Earlier related PRs: #18715 same for `queue_impl` #18227 same for `device_impl` #18141 similar for `platform_impl` Co-authored-by: andrei.elovikov <aeloviko@smtp.intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to pass an ugly
Self
in multiple methods after this. Further simplifications enabled by this change are left for subsequent PRs.