[NFC][SYCL] Ensure context_impl is always created via std::make_shared
#18795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ared` And once that is guaranteed, inherit it from `std::enable_shared_from_this`. Further simplifications based on `[shared|weak]_from_this` are left to subsequent PRs. Earlier related PRs: intel#18715 same for `queue_impl` intel#18227 same for `device_impl` intel#18141 similar for `platform_impl`
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
commented
Jun 3, 2025
| /// \param Device is an instance of SYCL device. | ||
| /// \param AsyncHandler is an instance of async_handler. | ||
| /// \param PropList is an instance of property_list. | ||
| context_impl(const device &Device, async_handler AsyncHandler, |
There was a problem hiding this comment.
This was unused before this PR.
againull
approved these changes
Jun 3, 2025
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 16, 2025
Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 16, 2025
Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981
aelovikov-intel
added a commit
that referenced
this pull request
Jun 17, 2025
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 17, 2025
Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 17, 2025
Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 24, 2025
Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007 intel#19030
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 24, 2025
…` ctor Splitting into two PRs would result in unnecessary temporarily adjustments and merge conflicts later on between these changes, so perform in a single PR. They are both small enough anyway. Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007 intel#19030 intel#19123
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 25, 2025
aelovikov-intel
added a commit
that referenced
this pull request
Jun 25, 2025
…` ctor (#19126) Splitting into two PRs would result in unnecessary temporarily adjustments and merge conflicts later on between these changes, so perform in a single PR. They are both small enough anyway. Continuation of the refactoring in #18795 #18877 #18966 #18979 #18980 #18981 #19007 #19030 #19123
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 25, 2025
Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007 intel#19030 intel#19123 intel#19126
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 25, 2025
Subsequently, use `getContextImpl` instead of `getContextImplPtr` when possible. Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007 intel#19030 intel#19123 intel#19126
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 25, 2025
Subsequently, use `getContextImpl` instead of `getContextImplPtr` when possible. Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007 intel#19030 intel#19123 intel#19126
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 25, 2025
`SetArgBasedOnType` argument is only used to pass to the `sampler_impl` ctor so update it. `getCGKernelInfo` is only called in a function that also calls `sampler_impl` ctor so updating its signuature allows to update that caller's local `ContextImpl` variable, so makes sense to do as part of this PR as well. Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007 intel#19030 intel#19123 intel#19126
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 25, 2025
`SetArgBasedOnType` argument is only used to pass to the `sampler_impl` ctor so update it. `getCGKernelInfo` is only called in a function that also calls `sampler_impl` ctor so updating its signuature allows to update that caller's local `ContextImpl` variable, so makes sense to do as part of this PR as well. Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007 intel#19030 intel#19123 intel#19126
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 25, 2025
…hpp` Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007 intel#19030 intel#19123 intel#19126
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 25, 2025
…hpp` Continuation of the refactoring in intel#18795 intel#18877 intel#18966 intel#18979 intel#18980 intel#18981 intel#19007 intel#19030 intel#19123 intel#19126
againull
pushed a commit
that referenced
this pull request
Jun 25, 2025
…19153) `SetArgBasedOnType` argument is only used to pass to the `sampler_impl` ctor so update it. `getCGKernelInfo` is only called in a function that also calls `sampler_impl` ctor so updating its signuature allows to update that caller's local `ContextImpl` variable, so makes sense to do as part of this PR as well. Continuation of the refactoring in #18795 #18877 #18966 #18979 #18980 #18981 #19007 #19030 #19123 #19126
aelovikov-intel
added a commit
that referenced
this pull request
Jun 26, 2025
aelovikov-intel
added a commit
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And once that is guaranteed, inherit it from
std::enable_shared_from_this. Further simplifications based on[shared|weak]_from_thisare left to subsequent PRs.Earlier related PRs:
#18715 same for
queue_impl#18227 same for
device_impl#18141 similar for
platform_impl