Skip to content

Partially revert "[SYCL][UR][L0] Use leak checker and API logging (fo… #18429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

igchor
Copy link
Member

@igchor igchor commented May 12, 2025

…r v2) from loader (#17536)"

This reverts commit b0b48a4 (except for test changes). The internal testing failed because the L0 loader used, was older than 1.21.2 (and didn't have leak checking implemented).

I did not revert changes in the tests as that doesn't make any difference and it will be easier to reapply the patch in the future.

@igchor igchor requested review from a team as code owners May 12, 2025 22:18
@igchor igchor requested a review from maarquitos14 May 12, 2025 22:18
@igchor igchor temporarily deployed to WindowsCILock May 12, 2025 22:19 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 12, 2025 22:44 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 12, 2025 22:44 — with GitHub Actions Inactive
…r v2) from loader (intel#17536)"

This reverts commit b0b48a4
(except for test changes). The internal testing failed because
the L0 loader used, was older than 1.21.2 (and didn't have
leak checking implemented).

I did not revert changes in the tests as that doesn't make
any difference and it will be easier to reapply the patch
in the future.
@igchor
Copy link
Member Author

igchor commented May 13, 2025

The tests failing on ARC are unrelated: #18416

@igchor
Copy link
Member Author

igchor commented May 13, 2025

@intel/llvm-gatekeepers this is ready to be merged

@aelovikov-intel aelovikov-intel merged commit af1a023 into intel:sycl May 13, 2025
47 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants