[SYCL][UR][L0] Use leak checker and API logging (for v2) from loader #17536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
force-pushed
the
leak_checker_from_loader
branch
from
38e60db to
5db0da7
Compare
igchor
force-pushed
the
leak_checker_from_loader
branch
from
5db0da7 to
15db475
Compare
igchor
force-pushed
the
leak_checker_from_loader
branch
from
15db475 to
578ae99
Compare
This ensures that calls to L0 made through UMF and user code are also tracked.
igchor
force-pushed
the
leak_checker_from_loader
branch
from
578ae99 to
0794cc0
Compare
igchor
force-pushed
the
leak_checker_from_loader
branch
from
0794cc0 to
9610315
Compare
igchor
force-pushed
the
leak_checker_from_loader
branch
from
9610315 to
866ca61
Compare
Account for the fact that when using API loggin from L0 loader, calls to zeMemFree from the test are also tracked.
This reverts commit 8f85bbb.
UR internally sets env variables to control behavior or L0 loader (e.g. enabling validation layer). If zeInit in test is called first the vars will have no effect.
Bensuo
reviewed
May 1, 2025
The adapter sets certain env variables during adapter init. Preloding it will set those variables and result in unexpected behavior for the legacy adater.
pbalcer
approved these changes
May 7, 2025
sergey-semenov
approved these changes
May 7, 2025
|
@intel/llvm-gatekeepers this should be ready for merge |
igchor
added a commit
to igchor/llvm
that referenced
this pull request
May 12, 2025
…r v2) from loader (intel#17536)" This reverts commit b0b48a4 (except for test changes). The internal testing failed because the L0 loader used, was older than 1.21.2 (and didn't have leak checking implemented). I did not revert changes in the tests as that doesn't make any difference and it will be easier to reapply the patch in the future.
aelovikov-intel
pushed a commit
that referenced
this pull request
May 13, 2025
#18429) …r v2) from loader (#17536)" This reverts commit b0b48a4 (except for test changes). The internal testing failed because the L0 loader used, was older than 1.21.2 (and didn't have leak checking implemented). I did not revert changes in the tests as that doesn't make any difference and it will be easier to reapply the patch in the future.
sarnex
pushed a commit
that referenced
this pull request
May 15, 2025
github-actions bot
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
May 16, 2025
This reapplies some of the changes from intel/llvm#17536 (without changes to leak_checker which broke internal testing). This fixes: intel/llvm#18463
kbenzie
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
May 19, 2025
This reapplies some of the changes from intel/llvm#17536 (without changes to leak_checker which broke internal testing). This fixes: intel/llvm#18463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.