[SYCL][RTC] Rename property to registered_names
#17266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Context: gmlueck#2 (comment) |
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
jopperm
force-pushed
the
rtc-rename-registered-kernels-lite
branch
from
3dc2353 to
0717026
Compare
Pennycook
approved these changes
Mar 3, 2025
Comment on lines
503
to
506
| This property is useful when the source language represents names differently in | ||
| the source code and the generated code. | ||
| For example, {cpp} function names in the generated code are "mangled" in an | ||
| implementation-defined way. |
There was a problem hiding this comment.
Nit: It might be useful to give another example here of names that are mangled, to make it clear that this behavior is not unique to functions. Something as simple as "{cpp} function names and the names of static variables at global scope", maybe?
sommerlukas
approved these changes
Mar 3, 2025
cperkinsintel
approved these changes
Mar 3, 2025
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
|
@intel/llvm-gatekeepers Please merge, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
registered_kernel_namesproperty to justregistered_names. The rationale is to prepare thekernel_compilerextension to support device globals in the future, for which we'll need help from the frontend to resolve source code names to mangled symbol names, in the same way we currently handle kernel names.Note: This PR only changes the user-facing property, whereas the implementation continues to use the similarly-named but independent
__sycl_detail__::__registered_kernels__attribute,!sycl_registered_kernelsnamed metdata and[SYCL/registered kernels]property set internally.