-
Notifications
You must be signed in to change notification settings - Fork 772
[SYCL][RTC] Add tests for JIT RTC #17182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
389acfa
to
ea1008a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixes in the examples look good to me.
|
||
// RUN: %{build} -o %t.out | ||
// RUN: %{run} %t.out 1 | ||
// RUN: %{l0_leak_check} %{run} %t.out 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that this is following a pattern that I set up, but these tests don't need both "run" and "run-with-leak-check". Just running with leak check is enough. On OpenCL (or any other non-supporting backend) the leak check env var will be ignored.
Let's drop the "run" lines.
And, while we are at it, these tests are also not using the arg, so we can drop the "1" at the end as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes requested. LGTM
#17266 just renamed the property to |
@intel/llvm-gatekeepers this looks ready to merge, thank you |
This PR is based on #17032. It adds runtime tests that match the examples from the spec changes in #11985, showing that the test run successfully using the JIT approach for RTC.
This PR also contains a few minor fixes in the example code in the RTC docs.