[SYCL][NFC] Remove multi_ptr<const void, Space>::operator multi_ptr<const void, Space> #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conversion operator to itself.
|
@v-klochkov, could you please have a look as you added this code? |
Looks like a no-brainer to me. |
bader
changed the title
bader
approved these changes
May 18, 2020
s-kanaev
reviewed
May 18, 2020
v-klochkov
approved these changes
May 18, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
May 18, 2020
…_docs * origin/sycl: (1867 commits) [SYCL] Implement USM vars and placeholder accessors passed to reduction (intel#1657) [SYCL] Fix post-commit testing (intel#1705) [SYCL][NFC] Remove multi_ptr<const void, Space>::operator multi_ptr<const void, Space> (intel#1702) [Doc] Readme update. (intel#1701) Support function pointers in cast instructions Adjust FPGA IVDep translation for embedded loops [SYCL] Fix host-to-host copy during copyback (intel#1692) [SYCL] Add information about dependencies used in CI [SYCL] Add runtime support for fsycl-id-queries-fit-in-int (intel#1685) Revert "Revert "[llvm][NFC] Cleanup uses of std::function in Inlining-related APIs"" StoreInst should store Align, not MaybeAlign [clang][slh] Add test for SLH feature checking macro [NFC] Deduplicate comment in PromoteMemoryToRegister.cpp [WebAssembly] Optimize splats of bitcasted vectors [LLD][ELF] Use offset in thin archives to disambiguate thinLTO members [AArch64][SVE] Implement AArch64ISD::SETCC_PRED [SVE] Restore broken LLVM-C ABI compatability IR: Remove extra name mangling from llvm.ptrmask [NFC] Whitespace fix inside OptParserEmitter [compiler-rt][CMAKE] Only add cmake link flags in standalone build ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes no sense (and won't be called) to have an implicit conversion operator to itself.