Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Add runtime support for fsycl-id-queries-fit-in-int #1685

Merged
merged 19 commits into from
May 15, 2020
Merged

[SYCL] Add runtime support for fsycl-id-queries-fit-in-int #1685

merged 19 commits into from
May 15, 2020

Conversation

s-kanaev
Copy link
Contributor

No description provided.

Alexander Batashev and others added 4 commits April 28, 2020 13:29
[SYCL] Add runtime support for fsycl-id-queries-fit-in-int
383e91c 
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
React to comments
12befcd 
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
Merge branch 'sycl' into private/abatashe/id_fit_int
15ee91c
[SYCL] Add and use __SYCL_ASSUME_ARRAY_INT and __SYCL_ASSUME_ID_INT
37c0f6c 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev requested review from rolandschulz, AlexeySachkov, MrSidims, a team and vladimirlaz and removed request for a team May 13, 2020 09:04
[SYCL] Fix style issue
c7e17d8 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev requested a review from a team as a code owner May 13, 2020 09:11
MrSidims
MrSidims reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional changes are LGTM, but please add testing for cases whre __SYCL_ASSUME_ID_INT and __SYCL_ASSUME_ARRAY_INT are used.

Sergey Kanaev added 3 commits May 14, 2020 12:45
[SYCL] Add ALWAYS_INLINE
f24aa75 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
[SYCL] Add checks
b5f053c 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
[SYCL] Run FileCheck
1849bfd 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev
Copy link
Contributor Author

Functional changes are LGTM, but please add testing for cases whre __SYCL_ASSUME_ID_INT and __SYCL_ASSUME_ARRAY_INT are used.

Done.

@s-kanaev s-kanaev requested review from vladimirlaz and MrSidims May 14, 2020 09:48
Sergey Kanaev added 5 commits May 14, 2020 13:26
[SYCL] Fix style issue.
d2feeb6 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Merge branch 'sycl' into private/abatashe/id_fit_int
cee60be
[SYCL] Remove unwanted changes.
cbc5e69 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
[SYCL] Add assume in size_t conversion operator
e334ad8 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
[SYCL] Add ALWAYS_INLINE
fa31f52 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
MrSidims
MrSidims previously approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-kanaev
Copy link
Contributor Author

@vladimirlaz ping

vladimirlaz
vladimirlaz previously approved these changes May 15, 2020
View reviewed changes
@MrSidims
Copy link
Contributor

Sorry for bringing it too late, but please consider moving the test to sycl/test/check_device_code/ directory.

[SYCL] Move test
a8d44f5 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev
Copy link
Contributor Author

Sorry for bringing it too late, but please consider moving the test to sycl/test/check_device_code/ directory.

Done

@s-kanaev s-kanaev dismissed stale reviews from vladimirlaz and MrSidims via a8d44f5 May 15, 2020 13:19
[SYCL] Add warning
abd3482 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev requested review from MrSidims and vladimirlaz May 15, 2020 13:30
@s-kanaev @mlychkov
[SYCL] Reword warning
53f4dbb 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>

Co-authored-by: Mikhail Lychkov <51128024+mlychkov@users.noreply.github.com>
@s-kanaev s-kanaev requested a review from mlychkov May 15, 2020 15:03
s-kanaev and others added 3 commits May 15, 2020 21:40
@s-kanaev @v-klochkov
[SYCL] Use a safer version of macro.
1ee97f2 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>

Co-authored-by: Vyacheslav Klochkov <34946562+v-klochkov@users.noreply.github.com>
[SYCL] Remove unwanted change
22c4c48 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
[SYCL] Fix style issue
65b9a41 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev requested a review from v-klochkov May 15, 2020 18:49
@bader bader merged commit fdcaeae into intel:sycl May 15, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request May 18, 2020
Merge remote-tracking branch 'origin/sycl' into private/abatashe/user…
8007710 
…_docs

* origin/sycl: (1867 commits)
  [SYCL] Implement USM vars and placeholder accessors passed to reduction (intel#1657)
  [SYCL] Fix post-commit testing (intel#1705)
  [SYCL][NFC] Remove multi_ptr<const void, Space>::operator multi_ptr<const void, Space> (intel#1702)
  [Doc] Readme update. (intel#1701)
  Support function pointers in cast instructions
  Adjust FPGA IVDep translation for embedded loops
  [SYCL] Fix host-to-host copy during copyback (intel#1692)
  [SYCL] Add information about dependencies used in CI
  [SYCL] Add runtime support for fsycl-id-queries-fit-in-int (intel#1685)
  Revert "Revert "[llvm][NFC] Cleanup uses of std::function in Inlining-related APIs""
  StoreInst should store Align, not MaybeAlign
  [clang][slh] Add test for SLH feature checking macro
  [NFC] Deduplicate comment in PromoteMemoryToRegister.cpp
  [WebAssembly] Optimize splats of bitcasted vectors
  [LLD][ELF] Use offset in thin archives to disambiguate thinLTO members
  [AArch64][SVE] Implement AArch64ISD::SETCC_PRED
  [SVE] Restore broken LLVM-C ABI compatability
  IR: Remove extra name mangling from llvm.ptrmask
  [NFC] Whitespace fix inside OptParserEmitter
  [compiler-rt][CMAKE] Only add cmake link flags in standalone build
  ...
@bader bader mentioned this pull request May 27, 2020
Merged
@s-kanaev s-kanaev deleted the private/abatashe/id_fit_int branch June 17, 2020 11:17
@wenju-he wenju-he mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruyk Ruyk Ruyk left review comments

@v-klochkov v-klochkov v-klochkov approved these changes

@rolandschulz rolandschulz Awaiting requested review from rolandschulz

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

@MrSidims MrSidims Awaiting requested review from MrSidims

@vladimirlaz vladimirlaz Awaiting requested review from vladimirlaz

@mlychkov mlychkov Awaiting requested review from mlychkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@s-kanaev @MrSidims @Ruyk @vladimirlaz @v-klochkov @mlychkov @bader