[SYCL][Driver] Enforce unique filenames when -save-temps is used #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of file table transformations, multiple intermediate files with the same extension are now occurring within any SYCL compilation (namely .txt and .table files). Unless we treat this during the static creation of comands, filename collision is bound to occur when saving temps. This breaks -save-temps compilations due to files being overwritten. This commit ensures that unique files are created upon a potential collision in the presence of -save-temps. Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
s-kanaev
reviewed
Apr 17, 2020
mdtoguchi
reviewed
Apr 17, 2020
|
Looks like a separate Windows-specific issue will have to be addressed before this patch can go in... |
@mdtoguchi, would a Windows |
Yes, that would be acceptable given the failure. The test is running clangxx (gnu mode) so Windows behavior isn't particularly interesting - but it should be addressed moving forward (and all of our other Windows |
- Do not execute the E2E test - Add checks for conflicts - XFAIL the E2E test on Windows Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
AGindinson
force-pushed
the
private/agindins/fsycl-save-temps
branch
2 times, most recently
from
c2ddb88 to
67e9559
Compare
mdtoguchi
approved these changes
Apr 20, 2020
alexbatashev
approved these changes
Apr 21, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 21, 2020
…c_abi_checks * origin/sycl: [SYCL][Driver] Enforce unique filenames when -save-temps is used (intel#1545) [SYCL] [xmethods] Allow replacing xmethod script (intel#1532) [SYCL] Add tests for inline asm feature (intel#1444) [SYCL][Doc] Add device_specific_kernel_queries extension. (intel#1540) [SYCL][USM] Remove unused header and unnecessary includes (intel#1537) Fix check-llvm dependencies (intel#1547) [SYCL] Add __SYCL_EXPORT to declaration of contextSetExtendedDeleter (intel#1531) [SYCL][Doc] Add static local memory query extension. (intel#1539) [SYCL][Doc] Add sycl_bitcast extension (intel#1541) [SYCL][NFC] Temporarily disable sporadically failing test (intel#1533) [SYCL][NFC] Adjust codeowners for sycl directory (intel#1529) [SYCL] Fix processing of spec consts referenced twice (intel#1524) [SYCL] Use correct macro name in export.hpp (intel#1527) [Driver][NFC] Fix -help information for -Xs options (intel#1530) [SYCL][Doc] Add Graph Scheduler design documentation (intel#1457) [SYCL] Add diagnostics for long double in device code (intel#1512) [SYCL] Add a mutex to state-modifying program functions (intel#1204) [SYCL][Test] Add Devicelib tests (intel#1256) [SYCL] Refactor semantic checks for variable types (intel#1513)
dwoodwor-intel
pushed a commit
to dwoodwor-intel/llvm
that referenced
this pull request
Jul 15, 2022
This option is useful for testing opaque pointers support and controlled transition of lit tests. Original commit: KhronosGroup/SPIRV-LLVM-Translator@0fe726f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of file table transformations, multiple
intermediate files with the same extension are now occuring
within any SYCL compilation (namely .txt and .table files).
Unless we treat this during the static creation of comands,
filename collision is bound to occur when saving temps.
This breaks -save-temps compilations due to files being
overwritten.
This commit ensures that unique files are created upon a
potential collision in the presence of -save-temps.
Signed-off-by: Artem Gindinson artem.gindinson@intel.com