Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Add tests for inline asm feature #1444

Merged
merged 10 commits into from
Apr 20, 2020
Merged

Conversation

MochalovaAn
Copy link
Contributor

Signed-off-by: amochalo anastasiya.mochalova@intel.com

sycl/test/inline-asm/asm_16_empty.cpp Outdated Show resolved Hide resolved
sycl/test/inline-asm/asm_16_empty.cpp Outdated Show resolved Hide resolved
sycl/test/inline-asm/asm_16_empty.cpp Outdated Show resolved Hide resolved
sycl/test/inline-asm/asm_16_empty.cpp Outdated Show resolved Hide resolved
sycl/test/inline-asm/asm_16_empty.cpp Outdated Show resolved Hide resolved
sycl/test/inline-asm/asm_16_empty.cpp Outdated Show resolved Hide resolved
sycl/test/inline-asm/asm_8_no_input_int.cpp Outdated Show resolved Hide resolved
@romanovvlad
Copy link
Contributor

Please, apply the comments above to the each file in the patch.

MochalovaAn and others added 2 commits April 15, 2020 12:57
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: Alexey Sachkov <alexey.sachkov@intel.com>
AlexeySachkov
AlexeySachkov previously approved these changes Apr 15, 2020
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion

sycl/test/inline-asm/include/asmhelper.h Outdated Show resolved Hide resolved
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
AlexeySachkov
AlexeySachkov previously approved these changes Apr 15, 2020
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
@MochalovaAn MochalovaAn requested a review from a team as a code owner April 16, 2020 18:29
sycl/test/inline-asm/asm_no_output.cpp Outdated Show resolved Hide resolved
sycl/test/inline-asm/asm_imm_arg.cpp Outdated Show resolved Hide resolved
sycl/test/inline-asm/asm_imm_arg.cpp Outdated Show resolved Hide resolved
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
@bader bader merged commit 148d04d into intel:sycl Apr 20, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 21, 2020
…c_abi_checks

* origin/sycl:
  [SYCL][Driver] Enforce unique filenames when -save-temps is used (intel#1545)
  [SYCL] [xmethods] Allow replacing xmethod script (intel#1532)
  [SYCL] Add tests for inline asm feature (intel#1444)
  [SYCL][Doc] Add device_specific_kernel_queries extension. (intel#1540)
  [SYCL][USM] Remove unused header and unnecessary includes (intel#1537)
  Fix check-llvm dependencies (intel#1547)
  [SYCL] Add __SYCL_EXPORT to declaration of contextSetExtendedDeleter (intel#1531)
  [SYCL][Doc] Add static local memory query extension. (intel#1539)
  [SYCL][Doc] Add sycl_bitcast extension (intel#1541)
  [SYCL][NFC] Temporarily disable sporadically failing test (intel#1533)
  [SYCL][NFC] Adjust codeowners for sycl directory (intel#1529)
  [SYCL] Fix processing of spec consts referenced twice (intel#1524)
  [SYCL] Use correct macro name in export.hpp (intel#1527)
  [Driver][NFC] Fix -help information for -Xs options (intel#1530)
  [SYCL][Doc] Add Graph Scheduler design documentation (intel#1457)
  [SYCL] Add diagnostics for long double in device code (intel#1512)
  [SYCL] Add a mutex to state-modifying program functions (intel#1204)
  [SYCL][Test] Add Devicelib tests (intel#1256)
  [SYCL] Refactor semantic checks for variable types (intel#1513)
pvchupin pushed a commit to pvchupin/llvm that referenced this pull request May 6, 2022
This is the easiest tranche of changes: where the pointer element type is
usually retrieved by looking a little further afield for the element type, or
via scavenging from sret/byval parameters.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@33012ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants