[SYCL][ABI-Break] Drop pi::assertion #14624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function should not be exported, but looking at its uses it seems like they call can be replaced with regular `assert` or a `static_assert` without hurting any functionality.
AlexeySachkov
added
the
abi-break
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
approved these changes
Jul 18, 2024
| // TODO: see if more sanity checks are possible. | ||
| sycl::detail::pi::assertion((sizeof(From) == sizeof(To)), | ||
| "assert: cast failed size check"); | ||
| static_assert(sizeof(From) == sizeof(To), "cast failed size check"); |
There was a problem hiding this comment.
This could even have performance benefits! 🥳
kbenzie
approved these changes
Jul 18, 2024
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| value.size() == 1, | ||
| "Temporary workaround requires that the " | ||
| "size of the input vector for make_event be equal to one."); | ||
| assert(value.size() == 1 && |
There was a problem hiding this comment.
technically, it's different behavior in release build (where new assert will be simply ignored), but I'm fine with that.
There was a problem hiding this comment.
I think this is more for correctness of our own SYCL RT code an all our tests are done with assertions enabled, so we should be able to catch it early still
aelovikov-intel
approved these changes
Jul 18, 2024
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
I doubt that it is caused by my changes, but I don't know if that's a known issue or not |
|
I've reported the failure in #14653. Considering that this patch should effectively be a non-functional change, I will proceed with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function should not be exported and looking at its uses it seems like they call can be replaced with regular
assertor astatic_assertwithout hurting any functionality.This is patch is essentially a by-product of #14145 and it is done to simplify that change, i.e. PI plugins removal should not be ABI-breaking by itself, we just need to cleanup some of our exported symbols.