[SYCL][ABI-Break] Drop pi::assertion (#14624)

This function should not be exported and looking at its uses it seems
like they call can be replaced with regular `assert` or a
`static_assert` without hurting any functionality.

This is patch is essentially a by-product of #14145 and it is
done to simplify that change, i.e. PI plugins removal should not be
ABI-breaking by itself, we just need to cleanup some of our exported
symbols.

Author: AlexeySachkov

sycl/include/sycl/detail/backend_traits_opencl.hpp

@@ -143,10 +143,9 @@ namespace pi {
 // Cast for std::vector<cl_event>, according to the spec, make_event
 // should create one(?) event from a vector of cl_event
 template <class To> inline To cast(std::vector<cl_event> value) {
-  sycl::detail::pi::assertion(
-      value.size() == 1,
-      "Temporary workaround requires that the "
-      "size of the input vector for make_event be equal to one.");
+  assert(value.size() == 1 &&
+         "Temporary workaround requires that the "
+         "size of the input vector for make_event be equal to one.");
   return cast<To>(value[0]);
 }
 

sycl/include/sycl/detail/pi.hpp

@@ -101,8 +101,6 @@ bool trace(TraceLevel level);
 // Report error and no return (keeps compiler happy about no return statements).
 [[noreturn]] __SYCL_EXPORT void die(const char *Message);
 
-__SYCL_EXPORT void assertion(bool Condition, const char *Message = nullptr);
-
 using PiPlugin = ::pi_plugin;
 using PiResult = ::pi_result;
 using PiPlatform = ::pi_platform;
@@ -260,9 +258,7 @@ namespace pi {
 // Want all the needed casts be explicit, do not define conversion
 // operators.
 template <class To, class From> inline To cast(From value) {
-  // TODO: see if more sanity checks are possible.
-  sycl::detail::pi::assertion((sizeof(From) == sizeof(To)),
-                              "assert: cast failed size check");
+  static_assert(sizeof(From) == sizeof(To), "cast failed size check");
   return (To)(value);
 }
 

sycl/source/detail/pi.cpp

@@ -217,8 +217,8 @@ std::string platformInfoToString(pi_platform_info info) {
 }
 
 std::string memFlagToString(pi_mem_flags Flag) {
-  assertion(((Flag == 0u) || ((Flag & (Flag - 1)) == 0)) &&
-            "More than one bit set");
+  assert(((Flag == 0u) || ((Flag & (Flag - 1)) == 0)) &&
+         "More than one bit set");
 
   std::stringstream Sstream;
 
@@ -522,11 +522,6 @@ template const PluginPtr &getPlugin<backend::ext_oneapi_hip>();
   std::terminate();
 }
 
-void assertion(bool Condition, const char *Message) {
-  if (!Condition)
-    die(Message);
-}
-
 // Reads an integer value from ELF data.
 template <typename ResT>
 static ResT readELFValue(const unsigned char *Data, size_t NumBytes,

sycl/test/abi/sycl_symbols_linux.dump

@@ -3288,7 +3288,6 @@ _ZN4sycl3_V16detail28getPixelCoordNearestFiltModeENS0_3vecIfLi4EEENS0_15addressi
 _ZN4sycl3_V16detail28getValueFromDynamicParameterERNS0_3ext6oneapi12experimental6detail22dynamic_parameter_baseE
 _ZN4sycl3_V16detail2pi25contextSetExtendedDeleterERKNS0_7contextEPFvPvES6_
 _ZN4sycl3_V16detail2pi3dieEPKc
-_ZN4sycl3_V16detail2pi9assertionEbPKc
 _ZN4sycl3_V16detail30UnsampledImageAccessorBaseHost10getAccDataEv
 _ZN4sycl3_V16detail30UnsampledImageAccessorBaseHost6getPtrEv
 _ZN4sycl3_V16detail30UnsampledImageAccessorBaseHostC1ENS0_5rangeILi3EEENS0_6access4modeEPviiNS0_2idILi3EEENS0_18image_channel_typeENS0_19image_channel_orderERKNS0_13property_listE

sycl/test/abi/sycl_symbols_windows.dump

@@ -3703,7 +3703,6 @@
 ?alloc_image_mem@experimental@oneapi@ext@_V1@sycl@@YA?AUimage_mem_handle@12345@AEBUimage_descriptor@12345@AEBVdevice@45@AEBVcontext@45@@Z
 ?alloc_image_mem@experimental@oneapi@ext@_V1@sycl@@YA?AUimage_mem_handle@12345@AEBUimage_descriptor@12345@AEBVqueue@45@@Z
 ?aspect_selector@_V1@sycl@@YA?AV?$function@$$A6AHAEBVdevice@_V1@sycl@@@Z@std@@AEBV?$vector@W4aspect@_V1@sycl@@V?$allocator@W4aspect@_V1@sycl@@@std@@@4@0@Z
-?assertion@pi@detail@_V1@sycl@@YAX_NPEBD@Z
 ?associateWithHandler@detail@_V1@sycl@@YAXAEAVhandler@23@PEAVAccessorBaseHost@123@W4target@access@23@@Z
 ?associateWithHandler@detail@_V1@sycl@@YAXAEAVhandler@23@PEAVSampledImageAccessorBaseHost@123@W4image_target@23@@Z
 ?associateWithHandler@detail@_V1@sycl@@YAXAEAVhandler@23@PEAVUnsampledImageAccessorBaseHost@123@W4image_target@23@@Z