[SYCL][NFC] Refactor lit.cfg.py #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySachkov
requested review from
dm-vodopyanov,
AGindinson and
sergey-semenov
Fznamznon
reviewed
Apr 2, 2020
AlexeySachkov
force-pushed
the
private/asachkov/refactor-messages-from-lit-py
branch
from
512cc9a to
35e2ef3
Compare
AlexeySachkov
changed the title
|
Tagging @Ruyk and @Alexander-Johnston to review as well |
AlexeySachkov
commented
Apr 3, 2020
AlexeySachkov
commented
Apr 3, 2020
AlexeySachkov
commented
Apr 3, 2020
alexbatashev
reviewed
Apr 4, 2020
AlexeySachkov
commented
Apr 6, 2020
AlexeySachkov
force-pushed
the
private/asachkov/refactor-messages-from-lit-py
branch
from
35e2ef3 to
884e455
Compare
bader
reviewed
Apr 7, 2020
| if not cuda: | ||
| opencl = True | ||
| config.available_features.add('opencl') |
There was a problem hiding this comment.
I think this code is not quite right. opencl feature should be enabled only if there is at least on OpenCL device in the system.
Could we fix this issue within this refactoring?
There was a problem hiding this comment.
Should be fixed now
Fznamznon
reviewed
Apr 8, 2020
AlexeySachkov
force-pushed
the
private/asachkov/refactor-messages-from-lit-py
branch
from
884e455 to
dbf5266
Compare
Switched to use "lit_config.note" instead of just "print": this emits potentially more usefult message, because it shows particular file and line where it was emitted, something like: ``` llvm-lit: /sycl/test/lit.cfg.py:117: note: Found available CPU device llvm-lit: /sycl/test/lit.cfg.py:154: warning: GPU device not found llvm-lit: /sycl/test/lit.cfg.py:169: warning: Accelerator device not found llvm-lit: /sycl/test/lit.cfg.py:198: warning: Couldn't find pre-installed AOT device compiler ocloc llvm-lit: /sycl/test/lit.cfg.py:198: warning: Couldn't find pre-installed AOT device compiler aoc llvm-lit: /sycl/test/lit.cfg.py:198: warning: Couldn't find pre-installed AOT device compiler opencl-aot ``` It also should be possible now to suppress this output via "-q" option to llvm-lit Removed extra items from "config.excludes" list since they were ignored anyway based on content of "config.suffixes" Simplified environment propagation by re-using existing helper functions Updated logic of `getDeviceCount` function to avoid printing useless messages Removed duplicated handling of path to SYCL tools directory Refactored handling of "opencl-aot" tool: now if it was built together with product, version from build directory will be used rather than a system one Signed-off-by: Alexey Sachkov <alexey.sachkov@intel.com>
AlexeySachkov
force-pushed
the
private/asachkov/refactor-messages-from-lit-py
branch
from
dbf5266 to
bbeb2f1
Compare
bader
approved these changes
Apr 9, 2020
Fznamznon
approved these changes
Apr 9, 2020
sergey-semenov
approved these changes
Apr 9, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 15, 2020
…duler_docs * origin/sycl: [SYCL][PI][CUDA] Implements get_native interoperability (intel#1332) [SYCL] Fix check-sycl test suite on systems w/o OpenCL (intel#1503) [SYCL][Doc] Update ExtendedAtomics documentation (intel#1487) [SYCL][CUDA] Expose context extended deleters on PI API (intel#1483) [SYCL][NFC] Remove a dropped environment variable from a test (intel#1506) [SYCL] Add opencl-aot to sycl-toolchain target (intel#1504) [SYCL] Allow to run deploy LIT tests from particular directory [SYCL][CUDA] Fix LIT testing with CUDA devices (intel#1300) [SYCL] Remove operator name keywords (intel#1501) [Driver][SYCL] Consider .lo files as static archives (intel#1500) [SYCL-PTX] Update the compiler design to describe the CUDA target (intel#1408) [SYCL] Fix library build on Windows (intel#1499) [SYCL][NFC] Refactor lit.cfg.py (intel#1452) [SYCL] Fixed sub-buffer memory allocation update (intel#1486) [SYCL] Ensure proper definition of spirv builtins for SYCL (intel#1393) [SYCL][CUDA] LIT XFAIL/UNSUPPORTED (intel#1303) [SYCL][Doc] Function-type kernel attribute extension (intel#1494)
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 15, 2020
…c_abi_checks * origin/sycl: (32 commits) [SYCL] Do not force LLVM_INCLUDE_TESTS variable (intel#1505) [SYCL][NFC] Align nd_item members with constructor initialization list (intel#1521) [SYCL] Move get_info_host implementation to header (intel#1514) [SYCL] Always use dynamic CRT for Unit tests (intel#1515) [SYCL][NFC] Temporarily disable sporadically failing test (intel#1526) [SYCL] Fix inline namespaces (intel#1525) [SYCL] Release notes for March'20 DPCPP implementation update (intel#1511) [SYCL][PI][CUDA] Implements get_native interoperability (intel#1332) [SYCL] Fix check-sycl test suite on systems w/o OpenCL (intel#1503) [SYCL][Doc] Update ExtendedAtomics documentation (intel#1487) [SYCL][CUDA] Expose context extended deleters on PI API (intel#1483) [SYCL][NFC] Remove a dropped environment variable from a test (intel#1506) [SYCL] Add opencl-aot to sycl-toolchain target (intel#1504) [SYCL] Allow to run deploy LIT tests from particular directory [SYCL][CUDA] Fix LIT testing with CUDA devices (intel#1300) [SYCL] Remove operator name keywords (intel#1501) [Driver][SYCL] Consider .lo files as static archives (intel#1500) [SYCL-PTX] Update the compiler design to describe the CUDA target (intel#1408) [SYCL] Fix library build on Windows (intel#1499) [SYCL][NFC] Refactor lit.cfg.py (intel#1452) ...
AlexeySachkov
deleted the
private/asachkov/refactor-messages-from-lit-py
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to use "lit_config.note" instead of just "print": this emits
potentially more usefult message, because it shows particular file and
line where it was emitted, something like:
It also should be possible now to suppress this output via "-q" option
to llvm-lit
Removed extra items from "config.excludes" list since they were ignored
anyway based on content of "config.suffixes"
Simplified environment propagation by re-using existing helper functions
Updated logic of
getDeviceCountfunction to avoid printing uselessmessages
Removed duplicated handling of path to SYCL tools directory
Refactored handling of "opencl-aot" tool: now if it was built together
with product, version from build directory will be used rather than a
system one