[SYCL][CUDA] Fix and cleanup more CUDA LIT fails #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
added a commit
to fwyzard/llvm
that referenced
this pull request
Mar 14, 2020
fwyzard
added a commit
to cms-patatrack/llvm
that referenced
this pull request
Mar 21, 2020
# Conflicts: # sycl/test/basic_tests/buffer/buffer_full_copy.cpp # sycl/test/basic_tests/buffer/subbuffer.cpp # sycl/test/basic_tests/buffer/subbuffer_interop.cpp # sycl/test/basic_tests/event.cpp # sycl/test/basic_tests/image_api.cpp # sycl/test/basic_tests/kernel_interop.cpp # sycl/test/fpga_tests/fpga_queue.cpp # sycl/test/linear_id/opencl-interop.cpp # sycl/test/ordered_queue/prop.cpp # sycl/test/usm/badmalloc.cpp # sycl/test/usm/memset.cpp
|
|
bjoernknafla
force-pushed
the
bjoern/lit-xfail-unsupported
branch
from
604b5f4 to
fc4e86e
Compare
bjoernknafla
changed the title
Remove XFAIL from passing tests. Change tests that should pass but fail as XFAIL, e.g., mark unexpectedly failing sub-buffer test to fix later for SYCL CUDA. Add `REQUIRES: opencl` for LIT tests requiring OpenCL. LIT tests that `REQUIRES: opencl` do not need an `UNSUPPORTED: cuda`. Mark tests of features not supported by SYCL CUDA with `UNSUPPORTED: cuda`. Tests that do not use the CUDA target triple do not require any CUDA related LIT marker. Tests that do not fail with CUDA do not require any CUDA specific LIT marker. Fix LIT test using `-Werror` to fail when the compiler driver warns about an unknown CUDA version as CUDA has otherwise nothing to do with the test. Adapt test to moved `pi_cuda.hpp` header. Some cleanup inside LIT configuration scripts. Signed-off-by: Bjoern Knafla <bjoern@codeplay.com>
bjoernknafla
force-pushed
the
bjoern/lit-xfail-unsupported
branch
from
fc4e86e to
2eec1d0
Compare
|
I have rebased this PR based on the last LIT CUDA fixes: #1458 |
bader
approved these changes
Apr 9, 2020
| @@ -3,7 +3,7 @@ | |||
| // RUN: %CPU_RUN_PLACEHOLDER %t.out | |||
| // RUN: %GPU_RUN_PLACEHOLDER %t.out | |||
| // RUN: %ACC_RUN_PLACEHOLDER %t.out | |||
| // UNSUPPORTED: cuda | |||
There was a problem hiding this comment.
Yes because the test (as quite a few others) has an extension check early on and passes if the pipes extension is not found.
There was a problem hiding this comment.
Would you prefer to mark all the fpga tests as not supported by CUDA? I am not entirely sure if the test semantics only work for accelerators anyway, in which case I could also quickly add REQUIRED: accelerator to all of them.
There was a problem hiding this comment.
I'm fine with this change actually.
We probably should have some common guidance for test behavior in unsupported environment and align all the tests in a separate PR.
+@MrSidims
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 15, 2020
…duler_docs * origin/sycl: [SYCL][PI][CUDA] Implements get_native interoperability (intel#1332) [SYCL] Fix check-sycl test suite on systems w/o OpenCL (intel#1503) [SYCL][Doc] Update ExtendedAtomics documentation (intel#1487) [SYCL][CUDA] Expose context extended deleters on PI API (intel#1483) [SYCL][NFC] Remove a dropped environment variable from a test (intel#1506) [SYCL] Add opencl-aot to sycl-toolchain target (intel#1504) [SYCL] Allow to run deploy LIT tests from particular directory [SYCL][CUDA] Fix LIT testing with CUDA devices (intel#1300) [SYCL] Remove operator name keywords (intel#1501) [Driver][SYCL] Consider .lo files as static archives (intel#1500) [SYCL-PTX] Update the compiler design to describe the CUDA target (intel#1408) [SYCL] Fix library build on Windows (intel#1499) [SYCL][NFC] Refactor lit.cfg.py (intel#1452) [SYCL] Fixed sub-buffer memory allocation update (intel#1486) [SYCL] Ensure proper definition of spirv builtins for SYCL (intel#1393) [SYCL][CUDA] LIT XFAIL/UNSUPPORTED (intel#1303) [SYCL][Doc] Function-type kernel attribute extension (intel#1494)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove XFAIL from passing tests.
Change tests that should pass but fail as XFAIL, e.g., mark unexpectedly failing sub-buffer test to fix later for SYCL CUDA.
Add
REQUIRES: openclfor LIT tests requiring OpenCL.LIT tests that
REQUIRES: opencldo not need anUNSUPPORTED: cuda.Mark tests of features not supported by SYCL CUDA with
UNSUPPORTED: cuda.Tests that do not use the CUDA target triple do not require any CUDA related LIT marker.
Tests that do not fail with CUDA do not require any CUDA specific LIT marker.
Fix LIT test using
-Werrorto fail when the compiler driver warns about an unknown CUDA version as CUDA has otherwise nothing to do with the test.Adapt test to moved
pi_cuda.hppheader.Some cleanup inside LIT configuration scripts.
Signed-off-by: Bjoern Knafla bjoern@codeplay.com